Image for Coq 8.5 (but not 8.4 nor 8.6) seems to have a broken python setup

[JasonGross]

Running

sudo apt-get update -y
sudo apt-get install -y python3 python3-pip
python3 -m pip install pyinstaller

works find on Coq 8.4 and Coq 8.6 but fails on Coq 8.5

log

  + (script @ line 27) $ python3 -m pip install pyinstaller
  Collecting pyinstaller
    Downloading https://files.pythonhosted.org/packages/bd/23/c5f0163b2049699cdbb511eac72798f017d4c9a3f4ba571fbef398156e3d/pyinstaller-5.13.2.tar.gz (4.1MB)
    Installing build dependencies: started
    Installing build dependencies: finished with status 'done'
  Collecting setuptools>=42.0.0 (from pyinstaller)
    Using cached https://files.pythonhosted.org/packages/c7/42/be1c7bbdd83e1bfb160c94b9cafd8e25efc7400346cf7ccdbdb452c467fa/setuptools-68.0.0-py3-none-any.whl
  Collecting altgraph (from pyinstaller)
    Downloading https://files.pythonhosted.org/packages/4d/3f/3bc3f1d83f6e4a7fcb834d3720544ca597590425be5ba9db032b2bf322a2/altgraph-0.17.4-py2.py3-none-any.whl
  Collecting pyinstaller-hooks-contrib>=2021.4 (from pyinstaller)
    Downloading https://files.pythonhosted.org/packages/2b/5f/30224db46281199f405b9c3b929f43a7d17591180b52f13c75c625dfc386/pyinstaller_hooks_contrib-2023.10-py2.py3-none-any.whl (288kB)
  Collecting importlib-metadata>=1.4 (from pyinstaller)
    Downloading https://files.pythonhosted.org/packages/ff/94/64287b38c7de4c90683630338cf28f129decbba0a44f0c6db35a873c73c4/importlib_metadata-6.7.0-py3-none-any.whl
  Collecting zipp>=0.5 (from importlib-metadata>=1.4->pyinstaller)
    Downloading https://files.pythonhosted.org/packages/5b/fa/c9e82bbe1af6266adf08afb563905eb87cab83fde00a0a08963510621047/zipp-3.15.0-py3-none-any.whl
  Collecting typing-extensions>=3.6.4; python_version < "3.8" (from importlib-metadata>=1.4->pyinstaller)
    Downloading https://files.pythonhosted.org/packages/ec/6b/63cc3df74987c36fe26157ee12e09e8f9db4de771e0f3404263117e75b95/typing_extensions-4.7.1-py3-none-any.whl
  Building wheels for collected packages: pyinstaller
    Running setup.py bdist_wheel for pyinstaller: started
    Running setup.py bdist_wheel for pyinstaller: finished with status 'error'
    Complete output from command /usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-dp4rc_64/pyinstaller/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/pip-wheel-8l05p09t --python-tag cp37:
    /tmp/pip-build-env-xdyq4_6v/lib/python3.7/site-packages/setuptools/__init__.py:84: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
    !!
    
            ********************************************************************************
            Requirements should be satisfied by a PEP 517 installer.
            If you are using pip, you can try `pip install --use-pep517`.
            ********************************************************************************
    
    !!
      dist.fetch_build_eggs(dist.setup_requires)
    running bdist_wheel
    running build
    running build_bootloader
    No precompiled bootloader found or compile forced. Trying to compile the bootloader for you ...
    Setting top to                           : /tmp/pip-install-dp4rc_64/pyinstaller/bootloader
    Setting out to                           : /tmp/pip-install-dp4rc_64/pyinstaller/bootloader/build
    Python Version                           : 3.7.3 (default, Oct 11 2023, 09:51:27) [GCC 8.3.0]
    Checking for 'gcc' (C compiler)          : /usr/bin/gcc
    Checking size of pointer                 : 8
    Platform                                 : Linux-64bit-intel detected based on compiler
    Checking for compiler flags -m64         : yes
      Platform                                 : Linux-64bit-intel detected based on compiler
      Checking for compiler flags -m64         : yes
      Checking for linker flags -m64           : yes
      Checking for compiler flags -Wno-error=unused-but-set-variable : yes
      Checking for library dl                                        : yes
      Checking for library pthread                                   : yes
      Checking for library m                                         : yes
      Checking for library z                                         : no
      The zlib development package is either missing or the shared library cannot be linked against. For security (and marginally better filesize), you should install the zlib-dev or zlib-devel packages with your system package manager, and try again. If you cannot do this (for example, distributions such as OpenWRT use sstrip on libraries, making linking impossible), then either use the --static-zlib option or set the PYI_STATIC_ZLIB=1 environment variable. If you are installing directly with pip, then use the environment variable.
      (complete log in /tmp/pip-install-dp4rc_64/pyinstaller/bootloader/build/config.log)
      ERROR: Failed compiling the bootloader. Please compile manually and rerun setup.py
      
      ----------------------------------------
  Command "/usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-dp4rc_64/pyinstaller/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-cxrsfxub/install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in /tmp/pip-install-dp4rc_64/pyinstaller/

[erikmd]

Hi @JasonGross, sorry for the delay :-/

But good news: it happens the coqorg/coq:8.5 image was stalled because of a non-portable Makefile command,
and this issue is now solved:

• 379f193
• https://gitlab.com/coq-community/docker-coq/-/pipelines/1374548848

So feel free to re-test the outcome on your side when you can, and I'll close the issue depending on your feedback.