Merch Store #73
Merged
Merch Store #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into merch-store-product-gallery
stricter eslint + relative import + interface cleanup
This reverts commit 4d54c70.
* Rename old merch components folder to merch_2023 * Add merch conditional rendering (WIP) * Add function for merch is active or not * Move merch types to data/types.ts * Make cents mandatory for Price, change getAllPrices to return a map and use it in getAllProductsAndVariants * Refactor merch.tsx getServerSideProps now that cents is guaranteed to be a member of Price * Move 2024 MerchCard to its own file in components * Fix imports for merch.tsx * Fix cart.tsx import * Fix pagination issue causing some sweaters (e.g. grey M/L) to show price $0 on cart * Fix import * Add merch closed messages to all relevant pages
lhvy
approved these changes
Jul 29, 2024
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Post merge testing and fixes before 2025