Update team for 2024 #69
Conversation
| icons: [faClipboard], | ||
| name: "HR", | ||
| description: `The HR portfolio is committed to strengthening teamwork and cross-portfolio communication within the society. They are responsible for organizing internal events, to help shape our culture at Co-op Soc.`, | ||
| members: ["Stella Lin", "James Liao", "Aiden Ahmad", "Rashid Abuzarov"], |
There was a problem hiding this comment.
Formatting - one per line. Make sure to set up eslint / formatter, ask @lhvy for help if needed
There was a problem hiding this comment.
Don't think this was done, I meant something like:
members: [
"Stella Lin",
"James Liao",
"Aiden Ahmad",
"Rashid Abuzarov",
]Should be automated by the linter/formatter. Let me know if the formatter chose to do it this way, but looks more like you just not setting it up yet.
|
Fixed code based on feedback |
|
Also be mindful of commit naming conventions, eg starting with a capital |
|
Will keep it lowercase in future commits. Thanks Nick. |
| icons: [faClipboard], | ||
| name: "HR", | ||
| description: `The HR portfolio is committed to strengthening teamwork and cross-portfolio communication within the society. They are responsible for organizing internal events, to help shape our culture at Co-op Soc.`, | ||
| members: ["Stella Lin", "James Liao", "Aiden Ahmad", "Rashid Abuzarov"], |
There was a problem hiding this comment.
Don't think this was done, I meant something like:
members: [
"Stella Lin",
"James Liao",
"Aiden Ahmad",
"Rashid Abuzarov",
]Should be automated by the linter/formatter. Let me know if the formatter chose to do it this way, but looks more like you just not setting it up yet.
Actually, it should be sentence case like you had in a few of them, like "Update team data after 2024 EGM" and "Change Rashid's surname" - first letter should be capitalised. Good use of imperative verbs by the way. |
|
Hey Nick, ive made the formatting changes, not too sure how to set up eslint yet, hopefully we can discuss on Wednesday. |
|
Checked on my machine, formatting is fine. Good to merge. |
Changed Co-op Soc team for 2024