Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the timestamp really needed in the parsed IDL? #12

Open
colega opened this issue Dec 22, 2017 · 2 comments
Open

Is the timestamp really needed in the parsed IDL? #12

colega opened this issue Dec 22, 2017 · 2 comments

Comments

@colega
Copy link

colega commented Dec 22, 2017

Having the timestamp in the parsed IDL (and a similar one in the autogenerated Go code) makes it impossible to generate same binaries twice from the same code.

It also adds unnecessary complexity of merging if two people have regenerated the code from IDLs in the same repository.

Is there any benefit of having that timestamp included in the parsed IDL?

@coopernurse
Copy link
Owner

It can be useful for tracing build issues, but I would be fine with adding a switch to the barrister CLI that would omit it from the generated JSON

@colega
Copy link
Author

colega commented Jan 24, 2018

Added a flag in #13, after this it would be interesting to skip them in the generated Go code too, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants