Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTC Field length validation #276

Merged
merged 19 commits into from
Apr 13, 2020
Merged

MTC Field length validation #276

merged 19 commits into from
Apr 13, 2020

Commits on Apr 1, 2020

  1. refactor(Feed): allow additional validators

    @landonreed
    landonreed committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    b85a922 View commit details
    Browse the repository at this point in the history

  2. test(MTC): Set up test files for MTC field length validation. 

    Some modifications regarding passing additional FeedValidator classes are included.

BREAKING CHANGE: Change in the type of optional arguments for GTFS.validate and Feed.validate
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    8b72831 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. feat(MTCValidator): Implement MTC validator and complete test.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    eeb6b32 View commit details
    Browse the repository at this point in the history

  2. docs: Refine comments and error messages.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    3f42515 View commit details
    Browse the repository at this point in the history

  3. refactor(FieldLengthError): Remove unused class.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    4058c9b View commit details
    Browse the repository at this point in the history

  4. refactor: Replace calling reflection on FeedValidator constructors wi… 

    …th callback approach.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    d423983 View commit details
    Browse the repository at this point in the history

  5. refactor(Feed): Replace callback interface to create MTCValidator wit… 

    …h Java's BiFunction equivalent.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    9b94a0e View commit details
    Browse the repository at this point in the history

  6. refactor(validate): remove list from custom validator interface

    @landonreed
    landonreed committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    13696e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. refactor(validator): rename validator creator

    @landonreed
    landonreed committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    df84840 View commit details
    Browse the repository at this point in the history

  2. refactor(validator): refactor Feed class and add javadoc

    @landonreed
    landonreed committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    d449b12 View commit details
    Browse the repository at this point in the history

  3. refactor(validator): fix npe

    @landonreed
    landonreed committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    b6aea3b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'field-length-validator' into field-length-validator-ltr-2

    @landonreed
    landonreed committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    19db9c2 View commit details
    Browse the repository at this point in the history

  5. refactor: fix build/imports

    @landonreed
    landonreed committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    fd249da View commit details
    Browse the repository at this point in the history

  6. refactor(GTFSTest): Use FeedValidatorCreator... syntax to remove test… 

    … method overrides.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    28b1dda View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. refactor(MTCValidator): Rename validation method + add overload, adju… 

    …st comments.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    707a119 View commit details
    Browse the repository at this point in the history

  2. fix(tests): Fix tests

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    7e97461 View commit details
    Browse the repository at this point in the history

  3. refactor(MTCValidator): Rename validateFieldLength; Add null check!

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    be1fc6d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'field-length-validator' of https://github.com/conveyal/… 

    …gtfs-lib into field-length-validator
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ffd601a View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. refactor(NewGTFSErrorType): Reorganize error types per PR comment.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    12ff728 View commit details
    Browse the repository at this point in the history