-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator: parity with Google transitfeed feedvalidator #167
Labels
Comments
landonreed
added a commit
that referenced
this issue
Dec 19, 2018
Merged
evansiroky
added a commit
that referenced
this issue
May 2, 2019
landonreed
added a commit
that referenced
this issue
May 24, 2019
landonreed
added a commit
that referenced
this issue
May 24, 2019
landonreed
added a commit
that referenced
this issue
May 24, 2019
Check that timepoints have times and that a stop time without pickup/drop off is a timepoint (otherwise it has no purpose) re #167
landonreed
added a commit
that referenced
this issue
May 24, 2019
5 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it would be useful to review the list of validation errors and warnings thrown by the Google transitfeed validator to ensure we're not missing anything glaring in gtfs-lib. I'm not sure this has been done (at least on the RDBMS code path) and I would like to say with confidence that gtfs-lib is performing every check made by this peer tool.
Edit:
Here's a running list of some checks I've discovered that we're not running (with the corresponding error type in NewGTFSErrorType or commit it was added):
shape contains points(actually I think this is covered by our referential integrity checks)gtfs-lib/src/main/java/com/conveyal/gtfs/error/NewGTFSErrorType.java
Line 37 in 76d89e9
SERVICE_NEVER_ACTIVE
)NO_SERVICE
)DUPLICATE_STOP
)The text was updated successfully, but these errors were encountered: