Merge pull request #152 from conveyal/validation-result-renaming

Rename variable to avoid confusion

Author: Landon Reed

src/main/java/com/conveyal/gtfs/validator/ServiceValidator.java

@@ -185,6 +185,9 @@ select durations.service_id, duration_seconds, days_active from (
                 if (date.isAfter(lastDate)) lastDate = date;
             }
             // Copy some useful information into the ValidationResult object to return to the caller.
+            // These variables are actually not directly tied to data in the calendar_dates.txt file.  Instead, they
+            // represent the first and last date respectively of any entry in the calendar.txt and calendar_dates.txt
+            // files.
             validationResult.firstCalendarDate = firstDate;
             validationResult.lastCalendarDate = lastDate;
             // Is this any different? firstDate.until(lastDate, ChronoUnit.DAYS);

src/main/java/com/conveyal/gtfs/validator/ValidationResult.java

@@ -1,13 +1,10 @@
 package com.conveyal.gtfs.validator;
 
-import java.awt.geom.Rectangle2D;
-import java.io.Serializable;
-import com.conveyal.gtfs.model.Pattern;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 
+import java.awt.geom.Rectangle2D;
+import java.io.Serializable;
 import java.time.LocalDate;
-import java.util.List;
 
 /**
  * An instance of this class is returned by the validator.
@@ -26,8 +23,15 @@ public class ValidationResult implements Serializable {
     public int errorCount;
     public LocalDate declaredStartDate;
     public LocalDate declaredEndDate;
+
+    /**
+     * the actual first and last date of service which is calculated in {@link ServiceValidator#complete}
+     * These variables are actually not directly tied to data in the calendar_dates.txt file.  Instead, they represent
+     * the first and last date respectively of any entry in the calendar.txt and calendar_dates.txt files.
+     */
     public LocalDate firstCalendarDate;
     public LocalDate lastCalendarDate;
+
     public int[] dailyBusSeconds;
     public int[] dailyTramSeconds;
     public int[] dailyMetroSeconds;