Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Add CTDirect.jl test problems #11

Open
ocots opened this issue Sep 3, 2024 · 5 comments · Fixed by #35
Open

[Dev] Add CTDirect.jl test problems #11

ocots opened this issue Sep 3, 2024 · 5 comments · Fixed by #35
Assignees
Labels
enhancement New feature or request internal dev Modification to the code is requested and should not affect user experiment

Comments

@ocots
Copy link
Member

ocots commented Sep 3, 2024

The list of problems is here: https://github.com/control-toolbox/CTDirect.jl/tree/main/test/problems.

@ocots ocots added the enhancement New feature or request label Sep 3, 2024
@ocots ocots self-assigned this Sep 3, 2024
@ocots ocots added the internal dev Modification to the code is requested and should not affect user experiment label Sep 3, 2024
@0Yassine0
Copy link
Collaborator

@ocots
Should we add the full list of problems from CTDirect.jl to the package?
And problems are written as OptimalControl models, I suppose we also need to convert it into JuMP models?

@ocots
Copy link
Member Author

ocots commented Sep 3, 2024

@PierreMartinon What do you think?

@0Yassine0
Copy link
Collaborator

0Yassine0 commented Sep 4, 2024

Here is the list of models from CTDirect :

  • beam (simple model)
  • bioreactor (from bocop)
  • bolza (simple model)
  • double_integrator (4 different simple models)
  • fuller (simple model)
  • goddard
  • insurance (from bocop)
  • jackson (from bocop)
  • parametric ( a model with a parameter)
  • robbins (from bocop)
  • simple_integrator (simple model)
  • swimmer (from bocop)
  • vanderpol

@0Yassine0 0Yassine0 linked a pull request Sep 9, 2024 that will close this issue
@ocots
Copy link
Member Author

ocots commented Sep 11, 2024

C'est très bien on n'ajoute pas les problèmes trop simpliste. Ils seront garder en interne.

@PierreMartinon
Copy link
Member

A bit late to the party, sorry.

@ocots, on our last meeting we discussed the issue of the format, eg in CTDirect the problem functions now return a 4-tuple such as

	def goddard begin
	 ...
	end

    return ((
        ocp = goddard,
        obj = 1.01257,
        name = "goddard",
        init = (state = [1.01, 0.05, 0.8],),
    ))

Is is unlikely we will find a common format for every framework, but I don't recall what we agreed upon: try to mutualize, have multiple versions of some problems here, or keep separate versions in each package ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal dev Modification to the code is requested and should not affect user experiment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants