Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all the parameters of netplugin & netmaster configurable through the ansible scripts #299

Open
neelimamukiri opened this issue Jan 10, 2017 · 4 comments
Assignees

Comments

@neelimamukiri
Copy link
Contributor

neelimamukiri commented Jan 10, 2017

Currently there are many options to netplugin & netmaster.
See
https://github.com/contiv/netplugin/blob/master/netplugin/netd.go
https://github.com/contiv/netplugin/blob/master/netmaster/main.go

We need a way to specify them using the ansible role.
Some args are already being provided https://github.com/contiv/ansible/blob/master/roles/contiv_network/templates/netmaster.j2 and https://github.com/contiv/ansible/blob/master/roles/contiv_network/templates/netplugin.j2

We need to either add the others or have a generic parameter list string as an option.

To provide context, I need this as I am trying to run netmaster & etcd on a subset of the nodes and netplugin uses localhost: 2379 for the default cluster. Currently there is no arg for cluster_store in the ansible.

@rhim rhim added this to the beta milestone Jan 25, 2017
@neelimamukiri
Copy link
Contributor Author

Cluster store field was added in 1d7d2d7.
So netplugin does not need any additional parameter.
TODO: add listen-url (:9999) and dns-enable (false) parameters to the netmaster installation. I will add these.

@rchirakk
Copy link

rchirakk commented Feb 2, 2017

@neelimamukiri, dns-enable (false) will be removed by contiv/netplugin#661

@neelimamukiri
Copy link
Contributor Author

Thanks @rchirakk. So netmaster port is the only parameter left to be added.

@rhim
Copy link
Contributor

rhim commented Feb 10, 2017

Since #331 isn't slated for beta, I am removing this issue from beta milestone.

@rhim rhim removed this from the beta milestone Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants