Skip to content

Commit 3f57891

Browse files
author
naman-contentstack
committed
Merge branch 'development' into feat/DX-5442
2 parents 5556ddb + 74deec5 commit 3f57891

File tree

4 files changed

+108
-417
lines changed

4 files changed

+108
-417
lines changed

.github/workflows/check-version-bump.yml

Lines changed: 35 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
# Ensures package.json and CHANGELOG.md are bumped compared to the latest tag when relevant files change.
1+
# Catches when developers forget to add a version bump for their changes.
2+
# Code changes (lib/, webpack/, dist/) require package.json + CHANGELOG.md.
3+
# Skips for: test-only, docs, .github (workflows/config).
24
name: Check Version Bump
35

46
on:
57
pull_request:
6-
paths:
7-
- 'package.json'
8-
- 'CHANGELOG.md'
98

109
jobs:
1110
version-bump:
@@ -17,12 +16,44 @@ jobs:
1716
with:
1817
fetch-depth: 0
1918

19+
- name: Detect changed files and version bump
20+
id: detect
21+
run: |
22+
if git rev-parse HEAD^2 >/dev/null 2>&1; then
23+
FILES=$(git diff --name-only HEAD^1 HEAD^2)
24+
else
25+
FILES=$(git diff --name-only HEAD~1 HEAD)
26+
fi
27+
VERSION_FILES_CHANGED=false
28+
echo "$FILES" | grep -qx 'package.json' && VERSION_FILES_CHANGED=true
29+
echo "$FILES" | grep -qx 'CHANGELOG.md' && VERSION_FILES_CHANGED=true
30+
echo "version_files_changed=$VERSION_FILES_CHANGED" >> $GITHUB_OUTPUT
31+
# Only lib/, webpack/, dist/, package.json count as release-affecting; .github/ and test/ do not
32+
CODE_CHANGED=false
33+
echo "$FILES" | grep -qE '^lib/|^webpack/|^dist/' && CODE_CHANGED=true
34+
echo "$FILES" | grep -qx 'package.json' && CODE_CHANGED=true
35+
echo "code_changed=$CODE_CHANGED" >> $GITHUB_OUTPUT
36+
37+
- name: Skip when only test/docs/.github changed
38+
if: steps.detect.outputs.code_changed != 'true'
39+
run: |
40+
echo "No release-affecting files changed (e.g. only test/docs/.github). Skipping version-bump check."
41+
exit 0
42+
43+
- name: Fail when version bump was missed
44+
if: steps.detect.outputs.code_changed == 'true' && steps.detect.outputs.version_files_changed != 'true'
45+
run: |
46+
echo "::error::This PR has code changes but no version bump. Please bump the version in package.json and add an entry in CHANGELOG.md."
47+
exit 1
48+
2049
- name: Setup Node
50+
if: steps.detect.outputs.code_changed == 'true' && steps.detect.outputs.version_files_changed == 'true'
2151
uses: actions/setup-node@v4
2252
with:
2353
node-version: '22.x'
2454

2555
- name: Check version bump
56+
if: steps.detect.outputs.code_changed == 'true' && steps.detect.outputs.version_files_changed == 'true'
2657
run: |
2758
set -e
2859
PKG_VERSION=$(node -p "require('./package.json').version.replace(/^v/, '')")

.talismanrc

Lines changed: 2 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,4 @@
11
fileignoreconfig:
2-
- filename: lib/contentstackClient.js
3-
checksum: f564f6eee5c17dc73abdeab4be226a3b37942893e149d907d2a4ef415c485c5e
4-
- filename: test/unit/globalField-test.js
5-
checksum: 25185e3400a12e10a043dc47502d8f30b7e1c4f2b6b4d3b8b55cdc19850c48bf
6-
- filename: lib/stack/index.js
7-
checksum: 6aab5edf85efb17951418b4dc4402889cd24c8d786c671185074aeb4d50f0242
8-
- filename: test/sanity-check/api/stack-test.js
9-
checksum: 198d5cf7ead33b079249dc3ecdee61a9c57453e93f1073ed0341400983e5aa53
10-
- filename: .github/workflows/secrets-scan.yml
11-
ignore_detectors:
12-
- filecontent
132
- filename: package-lock.json
14-
checksum: 0811efae3eb5a775708389d1e3e2affd47710a6e9cb2c2edc56171ba211fe013
15-
- filename: test/unit/ContentstackClient-test.js
16-
checksum: 5d8519b5b93c715e911a62b4033614cc4fb3596eabf31c7216ecb4cc08604a73
17-
- filename: .husky/pre-commit
18-
checksum: 52a664f536cf5d1be0bea19cb6031ca6e8107b45b6314fe7d47b7fad7d800632
19-
- filename: test/sanity-check/api/user-test.js
20-
checksum: 6bb8251aad584e09f4d963a913bd0007e5f6e089357a44c3fb1529e3fda5509d
21-
- filename: lib/stack/asset/index.js
22-
checksum: b3358310e9cb2fb493d70890b7219db71e2202360be764465d505ef71907eefe
23-
- filename: test/sanity-check/api/previewToken-test.js
24-
checksum: 9a42e079b7c71f76932896a0d2390d86ac626678ab20d36821dcf962820a886c
25-
- filename: lib/stack/deliveryToken/index.js
26-
checksum: 51ae00f07f4cc75c1cd832b311c2e2482f04a8467a0139da6013ceb88fbdda2f
27-
- filename: lib/stack/deliveryToken/previewToken/index.js
28-
checksum: b506f33bffdd20dfc701f964370707f5d7b28a2c05c70665f0edb7b3c53c165b
29-
- filename: examples/robust-error-handling.js
30-
checksum: e8a32ffbbbdba2a15f3d327273f0a5b4eb33cf84cd346562596ab697125bbbc6
31-
- filename: test/sanity-check/api/bulkOperation-test.js
32-
checksum: f40a14c84ab9a194aaf830ca68e14afde2ef83496a07d4a6393d7e0bed15fb0e
33-
- filename: test/unit/ContentstackHTTPClient-test.js
34-
checksum: 4043efd843e24da9afd0272c55ef4b0432e3374b2ca12b913f1a6654df3f62be
35-
- filename: test/unit/contentstack-test.js
36-
checksum: 2597efae3c1ab8cc173d5bf205f1c76932211f8e0eb2a16444e055d83481976c
37-
- filename: test/unit/concurrency-Queue-test.js
38-
checksum: 186438f9eb9ba4e7fd7f335dbea2afbae9ae969b7ae3ab1b517ec7a1633d255e
39-
- filename: lib/stack/branch/index.js
40-
checksum: f09b33c0a144139b7ffddcd7dc39fa6cee3bc42eadc06f11c8495c48d740341c
41-
version: "1.0"
3+
checksum: d4d4e7c312671307a62df2845cafe7385232530c7411b65f16e12949d0a1b609
4+
version: ""

0 commit comments

Comments
 (0)