Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umask=xxxx option to replace PodmanArgs=--umask=xxxx #25278

Open
geraveoyomama opened this issue Feb 10, 2025 · 7 comments · May be fixed by #25293
Open

Umask=xxxx option to replace PodmanArgs=--umask=xxxx #25278

geraveoyomama opened this issue Feb 10, 2025 · 7 comments · May be fixed by #25293
Labels
kind/feature Categorizes issue or PR as related to a new feature. quadlet

Comments

@geraveoyomama
Copy link

Feature request description

Adding a Umask= option to the quadlet generator to replace umask setting by way of PodmanArgs=--umask=xxxx. Since --umask is an explicit option and not a kit-bashed solution I think its deserving of its own generator key.

Suggest potential solution

Add Umask=xxxx to the generator in lieu of PodmanArgs=--umask=xxxx.

Have you considered any alternatives?

continue to use PodmanArgs=--umask=xxxx but its not so pretty nor set-and-forget friendly.

Additional context

No response

@geraveoyomama geraveoyomama added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 10, 2025
@Luap99 Luap99 added the quadlet label Feb 10, 2025
@giuseppe
Copy link
Member

would you like to open a PR to add it?

@geraveoyomama
Copy link
Author

Yes, though I have to admit I have not yet written Go. So I am trying to learn it a bit before I open one.

I apologise if it's not ok to submit a feature request with no PR to back it up.

@Luap99
Copy link
Member

Luap99 commented Feb 11, 2025

@geraveoyomama That is fine, adding a new field is pretty straight forward once you know what you have to touch, i.e. here is an example commit 54fce37

@rhatdan
Copy link
Member

rhatdan commented Feb 11, 2025

Please add Mask as well if you are going to add Umask.

@Luap99
Copy link
Member

Luap99 commented Feb 11, 2025

There is no --mask option? And not sure what that would be. Only --umask exist to set the process umask.

@geraveoyomama
Copy link
Author

geraveoyomama commented Feb 11, 2025

looking through the docs for quadlets I do already see a Mask= option.

@rhatdan
Copy link
Member

rhatdan commented Feb 11, 2025

Oops my brain was not reading the correctl. I saw umask and I was thinking Unmask/Mask for hiding parts of /sys and /proc/sys. Never mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants