fix: system prune JSON unmarshalling error in remote client

Add custom JSON methods to PruneReport to handle error field marshalling.

Fixes: #27267

Signed-off-by: Jan Rodák <[email protected]>

Author: Honny1

pkg/bindings/errors_test.go

@@ -0,0 +1,86 @@
+package bindings
+
+import (
+	"bytes"
+	"io"
+	"net/http"
+	"testing"
+
+	"github.com/containers/podman/v5/pkg/domain/entities/types"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+func TestBindings(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Bindings Suite")
+}
+
+var _ = Describe("APIResponse Process method", func() {
+
+	createMockResponse := func(jsonResponse string, statusCode int) *APIResponse {
+		response := &http.Response{
+			StatusCode: statusCode,
+			Body:       io.NopCloser(bytes.NewBufferString(jsonResponse)),
+			Header:     make(http.Header),
+		}
+		response.Header.Set("Content-Type", "application/json")
+		return &APIResponse{Response: response}
+	}
+
+	Describe("when processing SystemPruneReport", func() {
+		Context("with the exact JSON that caused the original marshalling error", func() {
+			It("should successfully unmarshal the response", func() {
+				// This is the exact JSON that was causing the unmarshalling error
+				jsonResponse := `{
+					"PodPruneReport": null,
+					"ContainerPruneReports": [
+						{
+							"Id": "aec04392e9b2fe7c4a36bc0cfa206dee35d7e403f7189df658ce909ccd598db7",
+							"Size": 8219
+						},
+						{
+							"Id": "3d8a8789524a0c44a61baa49ceedda7be069b0b3d01255b24013d2fb82168c7e",
+							"Err": "replacing mount point \"/tmp/CI_7Qsy/podman-e2e-213135586/subtest-1767990215/p/root/overlay/d9f554276b923c07bf708858b5f35774f9d2924fa4094b1583e56b33ae357af1/merged\": directory not empty",
+							"Size": 7238
+						},
+						{
+							"Id": "e9ef46f3a3cd43c929b19a01013be4d052bcb228333e61dcb8eb7dd270ae44c2",
+							"Size": 0
+						}
+					],
+					"ImagePruneReports": null,
+					"NetworkPruneReports": null,
+					"VolumePruneReports": null,
+					"ReclaimedSpace": 15457
+				}`
+
+				apiResponse := createMockResponse(jsonResponse, 200)
+				var report types.SystemPruneReport
+
+				err := apiResponse.Process(&report)
+				Expect(err).ToNot(HaveOccurred())
+
+				Expect(report.ContainerPruneReports).To(HaveLen(3))
+				Expect(report.ReclaimedSpace).To(Equal(uint64(15457)))
+
+				first := report.ContainerPruneReports[0]
+				Expect(first.Id).To(Equal("aec04392e9b2fe7c4a36bc0cfa206dee35d7e403f7189df658ce909ccd598db7"))
+				Expect(first.Size).To(Equal(uint64(8219)))
+				Expect(first.Err).To(BeNil())
+
+				second := report.ContainerPruneReports[1]
+				Expect(second.Id).To(Equal("3d8a8789524a0c44a61baa49ceedda7be069b0b3d01255b24013d2fb82168c7e"))
+				Expect(second.Size).To(Equal(uint64(7238)))
+				Expect(second.Err).ToNot(BeNil())
+				expectedErr := `replacing mount point "/tmp/CI_7Qsy/podman-e2e-213135586/subtest-1767990215/p/root/overlay/d9f554276b923c07bf708858b5f35774f9d2924fa4094b1583e56b33ae357af1/merged": directory not empty`
+				Expect(second.Err.Error()).To(Equal(expectedErr))
+
+				third := report.ContainerPruneReports[2]
+				Expect(third.Id).To(Equal("e9ef46f3a3cd43c929b19a01013be4d052bcb228333e61dcb8eb7dd270ae44c2"))
+				Expect(third.Size).To(Equal(uint64(0)))
+				Expect(third.Err).To(BeNil())
+			})
+		})
+	})
+})

pkg/domain/entities/reports/prune.go

@@ -1,11 +1,49 @@
 package reports
 
+import (
+	"encoding/json"
+	"errors"
+)
+
 type PruneReport struct {
 	Id   string `json:"Id"`
 	Err  error  `json:"Err,omitempty"`
 	Size uint64 `json:"Size"`
 }
 
+type pruneReportHelper struct {
+	Id   string `json:"Id"`
+	Err  string `json:"Err,omitempty"`
+	Size uint64 `json:"Size"`
+}
+
+func (pr *PruneReport) MarshalJSON() ([]byte, error) {
+	helper := pruneReportHelper{
+		Id:   pr.Id,
+		Size: pr.Size,
+	}
+	if pr.Err != nil {
+		helper.Err = pr.Err.Error()
+	}
+	return json.Marshal(helper)
+}
+
+func (pr *PruneReport) UnmarshalJSON(data []byte) error {
+	var helper pruneReportHelper
+	if err := json.Unmarshal(data, &helper); err != nil {
+		return err
+	}
+
+	pr.Id = helper.Id
+	pr.Size = helper.Size
+	if helper.Err != "" {
+		pr.Err = errors.New(helper.Err)
+	} else {
+		pr.Err = nil
+	}
+	return nil
+}
+
 func PruneReportsIds(r []*PruneReport) []string {
 	ids := make([]string, 0, len(r))
 	for _, v := range r {

pkg/domain/entities/reports/prune_test.go

@@ -0,0 +1,87 @@
+package reports
+
+import (
+	"encoding/json"
+	"errors"
+	"testing"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+func TestReports(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Reports Suite")
+}
+
+var _ = Describe("PruneReport JSON", func() {
+	Context("when marshaling and unmarshaling", func() {
+		tests := []struct {
+			name    string
+			report  *PruneReport
+			wantErr bool
+		}{
+			{
+				name: "report with error",
+				report: &PruneReport{
+					Id:   "test-container-id",
+					Err:  errors.New("test error message"),
+					Size: 1024,
+				},
+			},
+			{
+				name: "report without error",
+				report: &PruneReport{
+					Id:   "test-container-id",
+					Err:  nil,
+					Size: 2048,
+				},
+			},
+			{
+				name: "empty report",
+				report: &PruneReport{
+					Id:   "",
+					Err:  nil,
+					Size: 0,
+				},
+			},
+			{
+				name: "report with complex error message from failing test case",
+				report: &PruneReport{
+					Id:   "3d8a8789524a0c44a61baa49ceedda7be069b0b3d01255b24013d2fb82168c7e",
+					Err:  errors.New(`replacing mount point "/tmp/CI_7Qsy/podman-e2e-213135586/subtest-1767990215/p/root/overlay/d9f554276b923c07bf708858b5f35774f9d2924fa4094b1583e56b33ae357af1/merged": directory not empty`),
+					Size: 7238,
+				},
+			},
+			{
+				name: "report with special characters in error",
+				report: &PruneReport{
+					Id:   "container-special",
+					Err:  errors.New(`error with "quotes" and \backslashes\ and newlines`),
+					Size: 512,
+				},
+			},
+		}
+
+		for _, tt := range tests {
+			It("should handle "+tt.name, func() {
+				jsonData, err := json.Marshal(tt.report)
+				Expect(err).ToNot(HaveOccurred(), "Failed to marshal PruneReport")
+
+				var unmarshalled PruneReport
+				err = json.Unmarshal(jsonData, &unmarshalled)
+				Expect(err).ToNot(HaveOccurred(), "Failed to unmarshal PruneReport")
+
+				Expect(unmarshalled.Id).To(Equal(tt.report.Id), "Id should match")
+				Expect(unmarshalled.Size).To(Equal(tt.report.Size), "Size should match")
+
+				if tt.report.Err == nil {
+					Expect(unmarshalled.Err).To(BeNil(), "Error should be nil")
+				} else {
+					Expect(unmarshalled.Err).ToNot(BeNil(), "Error should not be nil")
+					Expect(unmarshalled.Err.Error()).To(Equal(tt.report.Err.Error()), "Error message should match")
+				}
+			})
+		}
+	})
+})