-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Disable retries on the CI #3400
Draft
apostasie
wants to merge
6
commits into
containerd:main
Choose a base branch
from
apostasie:disable-retries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: I can't make this to go green right now obviously... |
@ktock maybe you could help on these TestRunStargz is failing twice on this run:
Thanks in advance. |
This was referenced Sep 3, 2024
Merged
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
disable-retries
branch
from
September 25, 2024 05:38
93bf329
to
728910f
Compare
purported to fix scenarios when people commit simultaneously. However, the lock required a stateDir, sourced from the container label, which does not exist if the container was not created by nerdctl (eg: Kube). This commit fix this, by making sure we have a stateDir label. Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
disable-retries
branch
6 times, most recently
from
September 25, 2024 19:57
a9f168f
to
3251c46
Compare
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
disable-retries
branch
from
September 25, 2024 20:11
3251c46
to
450817d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of context about this in #3303.
TL;DR:
Retrying tests was a good idea to make the CI less painful to work with, but unfortunately, the side-effect is that it is just making things worse by basically allowing tests (and code) that can fail half of the time to still "pass".
Merging this PR will make things very painful for us for some time as we'll have to "pay back" and fix all the things that have probably been failing for months, but it will make things much better in the long run.
LMK your thoughts...