Merge pull request #3166 from Shikachuu/fix-login-username

Add repository login component username validation
containerd · Jul 14, 2024 · d9a9a83 · d9a9a83
2 parents d9d133c + f630815
commit d9a9a83
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cmd/nerdctl/login.go b/cmd/nerdctl/login.go
@@ -62,6 +62,10 @@ func processLoginOptions(cmd *cobra.Command) (types.LoginCommandOptions, error)
 		return types.LoginCommandOptions{}, err
 	}
 
+	if strings.Contains(username, ":") {
+		return types.LoginCommandOptions{}, errors.New("username cannot contain colons")
+	}
+
 	if password != "" {
 		log.L.Warn("WARNING! Using --password via the CLI is insecure. Use --password-stdin.")
 		if passwordStdin {