Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Halo computation in downsample function does not work correctly #33

Open
constantinpape opened this issue Nov 18, 2020 · 3 comments
Open

Halo computation in downsample function does not work correctly #33

constantinpape opened this issue Nov 18, 2020 · 3 comments

Comments

@constantinpape
Copy link
Owner

fortunately it is only necessary for the interpolate mode, for the others the 'natural' halo that results from upscaling the bounding box is sufficient.
@constantinpape constantinpape mentioned this issue Nov 20, 2020
Merged
@martinschorb
Copy link
Contributor

Do you think this is due to the same iterpolation?
Screenshot 2021-09-17 at 10 54 27

That's what happens when setting the EM sources to occluding.

@martinschorb
Copy link
Contributor

During my conversion, I call make_bdv without any specific downscale_mode.
Since when is the default nearest? I guess that should be what was used here...
So maybe it has instead something to do with the viewer dealing with downsampled occluding sources. Probably if the image size does not match the downscaling factors...

@martinschorb
Copy link
Contributor

just talked to @tischi In this case it is happening on the viewer side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@constantinpape @martinschorb