Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra check for displaysettings attribute #19

Open
constantinpape opened this issue Apr 22, 2020 · 1 comment
Open

Extra check for displaysettings attribute #19

constantinpape opened this issue Apr 22, 2020 · 1 comment

Comments

@constantinpape
Copy link
Owner

see bigdataviewer/bigdataviewer-playground#111

@constantinpape
Copy link
Owner Author

I have implemented a check for mandatory fields in the displaysettings attribute now:
https://github.com/constantinpape/pybdv/blob/master/pybdv/metadata.py#L7
Are there any other required fields @martinschorb @NicoKiaru ?

As a side note, I have also implemented support for passing List[int, str, bool, float] to the attributes now to support the color field. This is fine, but if we want anything more complicated, we should switch to json enconded strings as @NicoKiaru already suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant