Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

tag name into manifest when gb vendor fetch -tag <tag_name> #636

Open
jerome-laforge opened this issue Jul 13, 2016 · 3 comments
Open

tag name into manifest when gb vendor fetch -tag <tag_name> #636

jerome-laforge opened this issue Jul 13, 2016 · 3 comments

Comments

@jerome-laforge
Copy link

Hello,
Is it possible to add the tag name into manifest when we fetch the vendor by tag name ?
gb vendor fetch -tag 1.0.0 somewhere

have this

{
    "importpath": "somewhere",
    "repository": "https://somewhere",
    "tag": "1.0.0",
    "branch": "refs/tags/"
}

instead of

{
    "importpath": "somewhere",
    "repository": "https://somewhere",
    "tag": "a83829b6f1293c91addabc89d0571c246397bbf4",
    "branch": "HEAD"
}

Thx again for your kindness and your patience
Jérôme

@davecheney
Copy link
Contributor

Gb vendor already support this, however it does not record the tag name,
but the matching revision. This was an oversight in the v0 manifest format.
Rectifying it will require bumping the manifest format which is a large
piece of work.

On Wed, 13 Jul 2016, 08:13 Jérôme Laforge [email protected] wrote:

Hello,
Is it possible to add the tag name into manifest when we fetch the vendor
by tag name ?
gb vendor fetch -tag 1.0.0 somewhere

have this

{
"importpath": "somewhere",
"repository": "https://somewhere",
"tag": "1.0.0",
"branch": "refs/tags/"
}

instead of

{
"importpath": "somewhere",
"repository": "https://somewhere",
"tag": "a83829b6f1293c91addabc89d0571c246397bbf4",
"branch": "HEAD"
}

Thx again for your kindness and your patience
Jérôme


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#636, or mute the thread
https://github.com/notifications/unsubscribe/AAAcA1u9L14kPizHwUlAH92NCLqnk45qks5qVPJ9gaJpZM4JLdg0
.

@jerome-laforge
Copy link
Author

Maybe instead of modify the manifest format, is it possible to add the tag
name as comment?
That allows quickly know on which tag the dependency is pinned without
access to history of VCS.

Le 14 juil. 2016 10:23 PM, "Dave Cheney" [email protected] a
écrit :

Gb vendor already support this, however it does not record the tag name,
but the matching revision. This was an oversight in the v0 manifest format.
Rectifying it will require bumping the manifest format which is a large
piece of work.

On Wed, 13 Jul 2016, 08:13 Jérôme Laforge [email protected]
wrote:

Hello,
Is it possible to add the tag name into manifest when we fetch the vendor
by tag name ?
gb vendor fetch -tag 1.0.0 somewhere

have this

{
"importpath": "somewhere",
"repository": "https://somewhere",
"tag": "1.0.0",
"branch": "refs/tags/"
}

instead of

{
"importpath": "somewhere",
"repository": "https://somewhere",
"tag": "a83829b6f1293c91addabc89d0571c246397bbf4",
"branch": "HEAD"
}

Thx again for your kindness and your patience
Jérôme


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#636, or mute the thread
<
https://github.com/notifications/unsubscribe/AAAcA1u9L14kPizHwUlAH92NCLqnk45qks5qVPJ9gaJpZM4JLdg0

.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#636 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AJhF7-8960WqxjJKus-oJY4bsIrsGN3Uks5qVpqmgaJpZM4JLdg0
.

@davecheney
Copy link
Contributor

Nope, sorry. The manifest format is versioned to permit this kind of
change, there is no need for a workaround.

On Thu, Jul 14, 2016 at 3:02 PM, Jérôme Laforge [email protected]
wrote:

Maybe instead of modify the manifest format, is it possible to add the tag
name as comment?
That allows quickly know on which tag the dependency is pinned without
access to history of VCS.

Le 14 juil. 2016 10:23 PM, "Dave Cheney" [email protected] a
écrit :

Gb vendor already support this, however it does not record the tag name,
but the matching revision. This was an oversight in the v0 manifest
format.
Rectifying it will require bumping the manifest format which is a large
piece of work.

On Wed, 13 Jul 2016, 08:13 Jérôme Laforge [email protected]
wrote:

Hello,
Is it possible to add the tag name into manifest when we fetch the
vendor
by tag name ?
gb vendor fetch -tag 1.0.0 somewhere

have this

{
"importpath": "somewhere",
"repository": "https://somewhere",
"tag": "1.0.0",
"branch": "refs/tags/"
}

instead of

{
"importpath": "somewhere",
"repository": "https://somewhere",
"tag": "a83829b6f1293c91addabc89d0571c246397bbf4",
"branch": "HEAD"
}

Thx again for your kindness and your patience
Jérôme


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#636, or mute the thread
<

https://github.com/notifications/unsubscribe/AAAcA1u9L14kPizHwUlAH92NCLqnk45qks5qVPJ9gaJpZM4JLdg0

.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#636 (comment),
or mute the thread
<
https://github.com/notifications/unsubscribe/AJhF7-8960WqxjJKus-oJY4bsIrsGN3Uks5qVpqmgaJpZM4JLdg0

.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#636 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAAcA3NNfhtsYSnP_Hk0gtWvU3LgWx4cks5qVqPcgaJpZM4JLdg0
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants