Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirectOnError does not work #10

Open
judgej opened this issue May 13, 2019 · 2 comments
Open

redirectOnError does not work #10

judgej opened this issue May 13, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@judgej
Copy link
Member

judgej commented May 13, 2019

With reference to issue #8 cancelling an authorisation from the Xero authorisation flow should return the user to the application, but instead takes the user to the Xero organisation dashboard.

The redirectOnError parameter when fetching the temporary token should ensure the user correctly returns, but is not working as expected.

@judgej judgej added the bug Something isn't working label May 13, 2019
@judgej judgej self-assigned this May 13, 2019
@judgej
Copy link
Member Author

judgej commented May 13, 2019

It looks like it is used on the authorise URL and not the temporary token URL:

https://github.com/XeroAPI/Xero-Net/blob/master/Xero.Api.Example.Applications/TokenStoreAuthenticator.cs#L94

@judgej
Copy link
Member Author

judgej commented May 13, 2019

Fix made.

Undocumented, when the user returns from a cancellation, the user returns with an error + error_description pair of parameters, instead of oauth_problem + oauth_problem_advise. This needs a little more thought and some documentation on how to handle it consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant