Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

Allow client to pay for gas #1120

Open
kilrau opened this issue May 12, 2020 · 1 comment
Open

Allow client to pay for gas #1120

kilrau opened this issue May 12, 2020 · 1 comment
Labels
Enhancement New feature or request p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns.

Comments

@kilrau
Copy link

kilrau commented May 12, 2020

Is your feature request related to a problem? Please describe.
Follow-up of #27: we'd want the client to be able to pay for gas costs of collateralization.

Describe the solution you'd like
Node communicates that re-collateralization is necessary and the fee, client can choose to proceed (accept) or not, sends payment. Node keeps fee when forwarding payment.

Describe alternatives you've considered
No alternatives.

Additional context
Some thought should also be put in to evaluate if this can be used in a multi-hop future for intermediate forwarding nodes to keep a forwarding fee in lightning-style.

@kilrau kilrau added the Needs Triage Needs to be looked at and prioritized. label May 12, 2020
@ArjunBhuptani ArjunBhuptani added Enhancement New feature or request p2: User Shipping Needs Important (but minimal) refactors/enhancements/fixes needed for customers and removed Needs Triage Needs to be looked at and prioritized. labels May 19, 2020
@LayneHaber
Copy link
Contributor

Hmm well I guess this is technically possible with fairly minimal changes. First pass at the flow:

  1. Node prepares a meta transaction to the multisig
  2. Node requests + gains deposit rights, including the meta tx in the deposit application meta
  3. Node sets up listener to watch multisig for deposit
  4. Client emits the INSTALL_EVENT, which includes the metatx
  5. XUD application has code to submit the deposit to the multisig from the users wallet
  6. Node finds tx and removes listener, then rescinds deposit rights

The tasks on our end for this would look like:

  • allow node operators to specify if clients pay collateralization fees
  • update node collateralization logic to include the above
  • ensure clients emit install event (see [cf-core] Symmetric event emission #627 )

Alternatively, we could bake this into the fee structure (see #1139 )

@ArjunBhuptani ArjunBhuptani added p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns. and removed p2: User Shipping Needs Important (but minimal) refactors/enhancements/fixes needed for customers labels May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request p3: Features/refactors Larger enhancements driven by user needs + Refactors to improve bad patterns.
Projects
None yet
Development

No branches or pull requests

3 participants