Node v23 (#158)

* Update nan version for Node 23 and remove deprecated type

* Update semaphore pipeline to use matrix and add node 23

* Update package with dummy new version to force builds

* Update C++ minimum requirement

* Replace persistent function with Nan::Callback*

* Add gcc/g++ update in semaphore

* Update gcc version in non-tag tasks

* Revert package.json changes after testing

* Address comment and update agents to 22.04

* Change package.json for testing builds through dev tag

* Revert changes for 0.5.2-dev tag testing

* Assume yes for adding repo to make performance test run

* Make debian frontend noninteractive to prevent install from getting stuck

* Update CHANGELOG and README

Author: milindl

.semaphore/semaphore.yml

@@ -5,6 +5,7 @@ v1.0.0 is a feature release. It is supported for all usage.
 ## Enhancements
 
 1. Add support for an Admin API to fetch topic offsets (#156).
+2. Add support for Node v23 pre-built binaries (#158).
 
 ## Fixes
 

CHANGELOG.md

@@ -32,7 +32,7 @@ To use **Schema Registry**, use the existing [@confluentinc/schemaregistry](http
 
 The following configurations are supported:
 
-* Any supported version of Node.js (The two LTS versions, 18 and 20, and the latest versions, 21 and 22).
+* Any supported version of Node.js (The two LTS versions, 18 and 20, and the latest versions, 21, 22 and 23).
 * Linux (x64 and arm64) - both glibc and musl/alpine.
 * macOS - arm64/m1. macOS (Intel) is supported on a best-effort basis.
 * Windows - x64.

README.md

@@ -44,7 +44,7 @@
               }
             ],
             'cflags_cc' : [
-              '-std=c++17'
+              '-std=c++20'
             ],
             'msvs_settings': {
               'VCLinkerTool': {
@@ -135,7 +135,7 @@
                 'OS=="linux"',
                 {
                   'cflags_cc' : [
-                    '-std=c++17'
+                    '-std=c++20'
                   ],
                   'cflags_cc!': [
                     '-fno-rtti'
@@ -153,7 +153,7 @@
                     ],
                     'OTHER_CPLUSPLUSFLAGS': [
                       '-I/usr/local/opt/openssl/include',
-                      '-std=c++17'
+                      '-std=c++20'
                     ],
                   },
                 }

binding.gyp

@@ -54,7 +54,7 @@
   "dependencies": {
     "@mapbox/node-pre-gyp": "^1.0.11",
     "bindings": "^1.3.1",
-    "nan": "^2.17.0"
+    "nan": "^2.22.0"
   },
   "engines": {
     "node": ">=18.0.0"

package-lock.json

@@ -60,7 +60,7 @@ Dispatcher::~Dispatcher() {
   if (callbacks.size() < 1) return;
 
   for (size_t i=0; i < callbacks.size(); i++) {
-    callbacks[i].Reset();
+    delete callbacks[i];
   }
 
   uv_mutex_destroy(&async_lock);
@@ -107,24 +107,21 @@ void Dispatcher::Dispatch(const int _argc, Local<Value> _argv[]) {
   }
 
   for (size_t i=0; i < callbacks.size(); i++) {
-    v8::Local<v8::Function> f = Nan::New<v8::Function>(callbacks[i]);
-    Nan::Callback cb(f);
-    cb.Call(_argc, _argv);
+    callbacks[i]->Call(_argc, _argv);
   }
 }
 
 void Dispatcher::AddCallback(const v8::Local<v8::Function> &cb) {
-  Nan::Persistent<v8::Function,
-                  Nan::CopyablePersistentTraits<v8::Function> > value(cb);
-  // PersistentCopyableFunction value(func);
+  Nan::Callback *value = new Nan::Callback(cb);
   callbacks.push_back(value);
 }
 
 void Dispatcher::RemoveCallback(const v8::Local<v8::Function> &cb) {
   for (size_t i=0; i < callbacks.size(); i++) {
-    if (callbacks[i] == cb) {
-      callbacks[i].Reset();
+    if (callbacks[i]->GetFunction() == cb) {
+      Nan::Callback *found_callback = callbacks[i];
       callbacks.erase(callbacks.begin() + i);
+      delete found_callback;
       break;
     }
   }

package.json

@@ -19,10 +19,6 @@
 #include "rdkafkacpp.h" // NOLINT
 #include "src/common.h"
 
-typedef Nan::Persistent<v8::Function,
-  Nan::CopyablePersistentTraits<v8::Function> > PersistentCopyableFunction;
-typedef std::vector<PersistentCopyableFunction> CopyableFunctionList;
-
 namespace NodeKafka {
 
 class KafkaConsumer;
@@ -43,7 +39,7 @@ class Dispatcher {
   void Deactivate();
 
  protected:
-  std::vector<v8::Persistent<v8::Function, v8::CopyablePersistentTraits<v8::Function> > > callbacks;  // NOLINT
+  std::vector<Nan::Callback*> callbacks;  // NOLINT
 
   uv_mutex_t async_lock;