Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"tests/e2e/run-local" ignores cleanup failures #450

Open
ldoktor opened this issue Sep 23, 2024 · 0 comments
Open

"tests/e2e/run-local" ignores cleanup failures #450

ldoktor opened this issue Sep 23, 2024 · 0 comments

Comments

@ldoktor
Copy link
Contributor

ldoktor commented Sep 23, 2024

Describe the bug
Looking at https://github.com/confidential-containers/operator/actions/runs/10990240519/job/30510052789?pr=439 it looks like the status is not reported correctly at least when post-test check fails (in this case there were some pods still running after uninstalling the operator which is reported as Error in the Run e2e tests step but the CI reported PASS.

To Reproduce
Steps to reproduce the behavior:

  1. Run the tests/e2e/run-local.sh and fail in undo_changes

Describe the results you expected
IMO it should proceed with the cleanup and raise an error (not failure) with a different error afterwards.

Describe the results you received:
No report of unusual situation, green CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant