From 199a08a27fa7c53c0b74b9e719778ac17c80f299 Mon Sep 17 00:00:00 2001 From: Jules Ivanic Date: Sun, 18 Dec 2022 16:51:57 +0800 Subject: [PATCH] Rename `AdminClient.fromManagedJavaClient` to `AdminClient.fromScopedJavaClient` to follow ZIO2 conventions && Remove "Managed" from documentation (#117) --- .../src/main/scala/zio/kafka/admin/AdminClient.scala | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/zio-kafka/src/main/scala/zio/kafka/admin/AdminClient.scala b/zio-kafka/src/main/scala/zio/kafka/admin/AdminClient.scala index caec06afb..d6ee22a4e 100644 --- a/zio-kafka/src/main/scala/zio/kafka/admin/AdminClient.scala +++ b/zio-kafka/src/main/scala/zio/kafka/admin/AdminClient.scala @@ -48,7 +48,6 @@ import org.apache.kafka.common.{ Uuid } import zio._ - import zio.kafka.admin.acl._ import java.util.Optional @@ -1405,15 +1404,15 @@ object AdminClient { } def make(settings: AdminClientSettings): ZIO[Scope, Throwable, AdminClient] = - fromManagedJavaClient(javaClientFromSettings(settings)) + fromScopedJavaClient(javaClientFromSettings(settings)) def fromJavaClient(javaClient: JAdmin): URIO[Any, AdminClient] = ZIO.succeed(new LiveAdminClient(javaClient)) - def fromManagedJavaClient[R, E]( - managedJavaClient: ZIO[R with Scope, E, JAdmin] + def fromScopedJavaClient[R, E]( + scopedJavaClient: ZIO[R with Scope, E, JAdmin] ): ZIO[R with Scope, E, AdminClient] = - managedJavaClient.flatMap { javaClient => + scopedJavaClient.flatMap { javaClient => fromJavaClient(javaClient) }