feat: refactor archive type #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Jun 11, 2024
|
I like it! Maybe we can rename it |
sure! I've added //test to show how the refactor would look like and to see if the refactor is appropriate one |
done! |
baszalmstra
reviewed
Jun 13, 2024
|
|
||
| impl LocalArchive { | ||
| /// Extracts the contents of the archive to the specified destination. | ||
| pub fn extract_a_folder( |
There was a problem hiding this comment.
Can we also rename this to match the function it calls?
Suggested change
| pub fn extract_a_folder( | |
| pub fn extract_directory( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my previous PR, I thought about making Archive type a building block so that you could reuse where needed.
This is how you would use it in rattler-build:
prefix-dev/rattler-build#922