Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide findjsoncpp.cmake with conda package #25

Open
ManifoldFR opened this issue Oct 8, 2020 · 5 comments
Open

Provide findjsoncpp.cmake with conda package #25

ManifoldFR opened this issue Oct 8, 2020 · 5 comments

Comments

@ManifoldFR
Copy link

ManifoldFR commented Oct 8, 2020

The jsoncpp package normally provides the a cmake configuration file jsoncppConfig.cmake (open-source-parsers/jsoncpp#927) which allows to find the include and library files in a CMake project.

Unfortunately this is missing when installing the conda package. Normally we could find that file in $CONDA_PREFIX/lib/cmake/, but it is not the case. We can find it when installing libsjoncpp-dev using apt, at the location /usr/lib/x86_64-linux-gnu/cmake/jsoncpp on Ubuntu.

@jakirkham
Copy link
Member

Would raise this with upstream. This should be handled as part of the install step in their CMakeLists.txt

@ManifoldFR
Copy link
Author

ManifoldFR commented Nov 3, 2021 via email

@jakirkham
Copy link
Member

We're also publishing the latest version. So might be worth checking if things got fixed by upstream since this was raised

@jakirkham
Copy link
Member

Am seeing this in the logs:

-- Installing: $PREFIX/lib/cmake/jsoncpp/jsoncppConfig.cmake

There are a few other CMake files getting copied over. So maybe this is already solved.

That said, would be good to add a test to the package. Happy to accept a PR if you are up to it 🙂

@timsnyder
Copy link

It's definitely in the package but the permissions are jacked for some reason:

% pwd 
conda/pkgs/jsoncpp-1.9.5-h4bd325d_1/lib
% ls -l
total 312
drwx------ 3 spa.conda spa.conda_g   4096 Aug  3 16:28 cmake
lrwxrwxrwx 1 spa.conda spa.conda_g     19 Aug  3 16:28 libjsoncpp.so -> libjsoncpp.so.1.9.5
-rwxrwxr-x 2 spa.conda spa.conda_g 300736 Dec 30  2021 libjsoncpp.so.1.9.5
lrwxrwxrwx 1 spa.conda spa.conda_g     19 Aug  3 16:28 libjsoncpp.so.25 -> libjsoncpp.so.1.9.5
drwx------ 3 spa.conda spa.conda_g   4096 Aug  3 16:28 objects-Release
drwx------ 2 spa.conda spa.conda_g   4096 Aug  3 16:28 pkgconfig

The lib/cmake, lib/pkgconfig directories in the package have permissions 0x700 and that's strange. When I install the package as one user and have another try to use it, it causes problems. I'm going to look upstream to see why the permissions are so weird in their install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants