Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to CMake >= 3.30 (see policy CMP0167) #33

Closed
kordejong opened this issue Nov 19, 2024 · 3 comments
Closed

Port to CMake >= 3.30 (see policy CMP0167) #33

kordejong opened this issue Nov 19, 2024 · 3 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@kordejong
Copy link
Contributor

Before configuring HPX, patch this CMake script:

sed -i'' '135 s/MODULE/CONFIG/' $hpx_source_directory/cmake/HPX_SetupBoost.cmake

Probably provide a patch file and reference it in meta.yaml.

@hkaiser
Copy link

hkaiser commented Nov 19, 2024

I think we should apply this to HPX upstream...

@hkaiser
Copy link

hkaiser commented Nov 19, 2024

@kordejong
Copy link
Contributor Author

Aha, thanks for heads-up @hkaiser . I am now thinking that I may be able to solve the issue I am seeing with configuring an HPX client project by manipulating the CMake policy stack, setting the CMP0167 policy to OLD locally, when calling find_package(HPX). If that works I will close this issue again. No need to create a patch then, when HPX 1.11 will solve things anyway.

@kordejong kordejong self-assigned this Nov 20, 2024
@kordejong kordejong added the wontfix This will not be worked on label Dec 4, 2024
@kordejong kordejong closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants