Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• The test section contained an unexpected subsection name. script is not a valid subsection name.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

Tests pass on Linux/OSX but are failing on windows with what appears to be a fairly consistent message:

Traceback (most recent call last):
  File "D:\bld\fuzzysearch_1587057106696\test_tmp\tests\test_substitutions_only.py", line 142, in test_all_different
    self.search(substring, text, max_subs=max_subs),
  File "D:\bld\fuzzysearch_1587057106696\test_tmp\tests\test_substitutions_only.py", line 313, in search
    return hnm_subs(subsequence, sequence, max_subs)
  File "D:\bld\fuzzysearch_1587057106696\_test_env\lib\site-packages\fuzzysearch\substitutions_only.py", line 23, in has_near_match_substitutions
    for start_index in search_exact(subsequence, sequence):
  File "D:\bld\fuzzysearch_1587057106696\_test_env\lib\site-packages\fuzzysearch\search_exact.py", line 70, in search_exact
    return search_exact_byteslike(subsequence, sequence,
ValueError: end_index must be non-negative

Related, perhaps: taleinat/fuzzysearch#13

Confusingly, I can't reproduce this with a local windows build of fuzzysearch 0.7.1.

Hi @klauer, I just noticed this now...

I'd be happy to help diagnose the failing tests, but unfortunately their outputs are no longer available on Azure Pipelines.

I have a Windows machine available so I'll see if the tests happen to fail for me as well...

@taleinat - no problem. Fixing the merge conflict here should trigger another build - let me know if you still can't see the output from there.

For what it's worth, I had tried a while back to reproduce this locally on a Windows machine and couldn't.

So, on the Windows build, for some reason at least one of the Cython modules appears very broken. I'm can't tell why, yet, as I too cannot reproduce this failure on my Windows machine.

BTW, the Cython modules have their C code included in the source. Cython is not required at any stage.

Interesting - I don't think I had noticed the inclusion of the cython-generated C source files. Is that common for cython projects?

I might try a make clean-cython cython && setup.py build out of curiosity to see if it affects the windows builds in this PR.

I've started working on this. The issue doesn't seem to be with the Cython-based extensions.

@klauer, I've fixed what appears to be the source of this issue. The fix is available in version 0.7.3 which I've just released. Let's try this again with the new version.

Great! Will bump the version and retry.

Looks like it's still failing :(

I see build warnings that I don't get when building locally on Windows. I'm using a slightly different version of MSCV: 14.11.25503 vs. version 14.16.27023 used in the Azure DevOps job, perhaps that's the reason?

Hmm :/ it might be, but I don't believe we have control over that in the conda recipes. What's the differing warning you noticed?

Happy to try any other fixes you can think of - patches can be relatively easily applied on top of v0.7.3 without touching the source repo.

Is this being built with a standard version of Python or is it somehow customized?

Is there a way to try this manually in a similar environment so that I can to diagnose this?

In the feedstock, there's build-locally.py: https://conda-forge.org/docs/maintainer/updating_pkgs.html#testing-changes-locally which relies on Docker. Windows, sadly, is a different beast: https://conda-forge.org/docs/maintainer/knowledge_base.html#local-testing

conda-forge releases its own Python builds (as does anaconda), but I don't believe they're modified from stock in any significant way.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.