Add checks for duplicated refs when downloading from backup source #17813
+62
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
memsharded
reviewed
Feb 19, 2025
| @@ -120,6 +120,9 @@ def update_backup_sources_json(cached_path, conanfile, urls): | |||
|
|
|||
| try: | |||
| summary_key = str(conanfile.ref) | |||
| if set(summary["references"].keys()).difference({"unknown", summary_key}): | |||
There was a problem hiding this comment.
Possible false positives:
- Different packages with different user/channel, but downloading the same source
- Packages downloading sources of a vendored dependency that is also a Conan package elsewhere
- Package re-names (like changing style like
my_pkgtomypkgormypkg++tomypkgppto comply with Conan recommendations.
memsharded
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add checks for duplicated refs when downloading from backup source
Docs: Omit
To check with the team and see if this is not giving false positives