Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: use cppstd_flag(), clean up cppstd handling, use can_run() #25963

Closed
wants to merge 3 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 16, 2024

Summary

Changes to recipe: boost/[*]

Motivation

Fixes conan-io/conan#17322, which fails due to C++26 not yet being supported in the recipe.
Gets rid of about 250 lines of logic that was there solely to work around potentially missing compiler.cppstd info.

Details

Also replaces cross_building() used to disable running of test executables. not can_run() is a more appropriate check there.

cppstd_flag() is available since Conan 2.2.0, so I adjusted required_conan_version accordingly.

I'm aware of the request to leave Conan v1 legacy cleanup to the team, but this also fixes a functional issue in the recipe and seemed appropriate. Feel free to close this one if you disagree. I don't intend to open any additional ones.


@valgur
Copy link
Contributor Author

valgur commented Nov 25, 2024

Mostly superseded by #26030. @uilianries, maybe you can incorporate the can_run() improvements as well.

@valgur valgur closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] "None" is not a known value of feature <cxxstd>
1 participant