Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] GnuToolchain's make_args does not handle empty values correctly #17171

Open
valgur opened this issue Oct 16, 2024 · 1 comment
Open

[bug] GnuToolchain's make_args does not handle empty values correctly #17171

valgur opened this issue Oct 16, 2024 · 1 comment
Assignees

Comments

@valgur
Copy link
Contributor

valgur commented Oct 16, 2024

Describe the bug

Conan: 2.8.0

When using the GnuToolchain generator in the following manner

tc = GnuToolchain(self)
tc.make_args["PREFIX"] = ""
...
tc.generate()

where an empty string is passed as a value, the resulting make command fails with:

libbpf/1.4.6: RUN: make PREFIX -j16
make: *** No rule to make target 'PREFIX'.  Stop.

Expected:

libbpf/1.4.6: RUN: make PREFIX= -j16
...

The make_args and configure_args properties should always map "" and any other falsy values besides None to a <key>= command-line argument.

Also, the make_args should probably never create arguments without a = symbol altogether. Any --xyz flags to make seem better suited to the args keyword in autotools.make(args=[...]).

How to reproduce it

No response

@valgur
Copy link
Contributor Author

valgur commented Oct 16, 2024

/cc @franramirez688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants