Fix: Zip Deployer crashes when subfolder exist #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AbrilRBS
reviewed
Feb 12, 2025
| if not os.path.isdir(search_dir): | ||
| return [] | ||
| files = [] | ||
| for f in os.listdir(search_dir): |
There was a problem hiding this comment.
I wonder if using os.walkdir is a better approach here, but I like the current minimal diff nevertheless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the zip deployer crashes with an exception when a subfolder exists inside bin or lib. This can easily be checked with
The change add sone unittest with a minimal project that creates a folder inside
binto ensure that it does not crash like the current version does.