assimp: fix bug where using draco compression in gltf2 file errors #26705
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o is used in assimp. Add test file to verify that the importer works with draco compression.
|
|
jcar87
reviewed
Feb 27, 2025
| @@ -29,3 +29,8 @@ def test(self): | |||
|
|
|||
| bin_c_path = os.path.join(self.cpp.build.bindirs[0], "test_package_c") | |||
| self.run(f"{bin_c_path} {obj_path}", env="conanrun") | |||
|
|
|||
| # Check that a GLTF2 file with draco compression can be loaded without error | |||
There was a problem hiding this comment.
Hi @bacusters - we no longer allow checking binary files into the repository. Please note that the intended purpose of the test package is to check that find_package works in CMake, that the compiler can resolve includes from the package, and that the linker can correctly resolve the library and symbols from the binary files , and not a functionality check. Apologies as some legacy test packages still don't reflect this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure -DASSIMP_ENABLE_DRACO preprocessor symbol is defined when draco is used in assimp. Add test file to verify that the importer works with draco compression.
Summary
Changes to recipe: assimp/*
Motivation
Fixes #26695. After a refactor, the draco support was no longer enabled in assimp when using GLTF2, even though the dependency was being built. A preprocessor definition was missing to make Assimp aware that draco is available.
Details
Change adds a extra call in the injected
conan_deps.cmaketo define the preprocessor symbolASSIMP_ENABLE_DRACO. This ensures that the GLTF2 importer of Assimp will support and use draco compression instead of throwing an error. Added another small test file that uses GLTF2 with compression and added a run in the test_package to verify that it works after the fix.