add NFIR package #26698
Open
add NFIR package #26698
+237
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-krupa
force-pushed
the
add-NFIR-recipe
branch
5 times, most recently
from
694cf75 to
5b9bf70
Compare
valgur
reviewed
Feb 26, 2025
valgur
reviewed
Feb 26, 2025
valgur
reviewed
Feb 26, 2025
valgur
reviewed
Feb 26, 2025
valgur
reviewed
Feb 26, 2025
valgur
reviewed
Feb 26, 2025
valgur
reviewed
Feb 26, 2025
valgur
reviewed
Feb 26, 2025
recipes/nfir/all/patches/0001-find-OpenCV-provided-by-conan_toolchain.cmake.patch
Outdated
Show resolved
Hide resolved
valgur
reviewed
Feb 26, 2025
recipes/nfir/all/patches/0002-enable-choose-between-shared-and-static-library.patch
Outdated
Show resolved
Hide resolved
valgur
reviewed
Feb 26, 2025
recipes/nfir/all/patches/0004-set-NFIR-executable-name-to-NFIR_bin-tool.patch
Outdated
Show resolved
Hide resolved
valgur
reviewed
Feb 26, 2025
|
@valgur, thank you for the helpful feedback. I'm curious, the PR was reviewed very quickly after being opened. However, I have two other PRs that have been waiting for review for several weeks/months with no activity. Is there any official way I can request a review for a PR? |
tomas-krupa
force-pushed
the
add-NFIR-recipe
branch
2 times, most recently
from
2713dbf to
8a1f55c
Compare
tomas-krupa
force-pushed
the
add-NFIR-recipe
branch
from
1c615bb to
f3dde3c
Compare
That's just how things work down here, I guess. 😐 I'm just a regular contributor, and don't have direct bearing on whether this gets merged or not, but I hope my feedback helps things move along a bit faster at least. |
tomas-krupa
force-pushed
the
add-NFIR-recipe
branch
4 times, most recently
from
0b55184 to
f7e39b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIST-made library and tool NFIR/0.2.0 conanized
Motivation
NFIR is a library (and tool) capable of upsampling or downsampling fingerprint images according to NIST standards. It can now be seamlessly integrated as a Conan dependency.
Details
Since the official NIST repository does not contain any Releases, I had to fork the repository and create a Release myself in order to link the Conan sources to it.