libvdpau: requires C++ compiler, fix X11 linking #26659
Open
+38
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't need to add libcxx to system_libs, though, since it's a shared library.
Otherwise fails to use non-system x11 with src/include/vdpau/vdpau_x11.h:44:10: fatal error: X11/Xlib.h: No such file or directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: libvdpau/[*]
Motivation
Fails to compile if some system C++ compiler is not found, since removing
compiler.cppstdandcompiler.libcxxmakes Conan not pass the compiler executable.Details
transitive_headers=Truecould also be used, but its use is limited tovdpau/vdpau_x11.h, so I would keep it optional.