Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimalloc: Added recipe option for MI_WIN_REDIRECT #26647

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NickGaertner
Copy link

Summary

Changes to recipe: mimalloc/*

proposes fix for #26646

Motivation

Adding an option for MI_WIN_REDIRECT adds transparency and avoids hard to find build errors. See #26646


@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

@NickGaertner NickGaertner changed the title Added recipe option for MI_WIN_REDIRECT mimalloc: Added recipe option for MI_WIN_REDIRECT Feb 19, 2025
@RazielXYZ
Copy link
Contributor

I agree that redirect should be configurable in the conan package. However, I think redirect only makes sense for shared override builds under windows with a msvc dynamic runtime.
Perhaps checks should be added to that effect, and the option deleted otherwise, similar to the other checks in config_options, configure and validate?

@NickGaertner
Copy link
Author

Yeah, agreed. I didn't remove the option in configure since it could result in silently misconfigured builds again. Please let me know if there's a good reason to remove the option nonetheless; I'm not that familiar with conan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants