influxdb-cxx: add recipe #19148
influxdb-cxx: add recipe #19148
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| tc.cache_variables["INFLUXCXX_TESTING"] = False | ||
| tc.cache_variables["INFLUXCXX_WITH_BOOST"] = self.options.boost | ||
| if self.options.shared: | ||
| tc.preprocessor_definitions["InfluxDB_EXPORTS"] = 1 |
There was a problem hiding this comment.
This one looks a little unusual - is it not possible to build the shared variant without the consumers defining preprocessor definitions externally?
There was a problem hiding this comment.
This shouldn't be necessary as the define is handled by CMakes GenerateExportHeader. However, there are reports of issues on MSVC. I wasn't able to reproduce the issue, but I'm no MSVC dev.
There was a problem hiding this comment.
@jcar87
You are right.
I don't understand why this definition is required.
But without this, there are compilation errors on MSVC shared build.
There was a problem hiding this comment.
Thanks @toge - there is indeed a pre-existing issue, I've updated the recipe to reference it
I've had a chance to investigate the root cause and made a comment here:
offa/influxdb-cxx#194 (comment)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jcar87
force-pushed
the
influxdb-cxx-add-recipe
branch
from
e65b9a2
to
f1d3e28
Compare
This comment has been minimized.
This comment has been minimized.
jcar87
force-pushed
the
influxdb-cxx-add-recipe
branch
from
f1d3e28
to
917bbf5
Compare
| int main() | ||
| { | ||
| try { | ||
| auto influxdb = influxdb::InfluxDBFactory::Get("xyz://foobar"); |
There was a problem hiding this comment.
I've changed this to not reference localhost - in the odd chance something is actually running. Test packages in Conan center must not make network requests to any resource whatsover.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
Specify library name and version: influxdb-cxx/0.7.1
Try to close #19125.