[aws refactor] aws-sdk-cpp: Review dependencies, add new version and remove old one #24924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I just tried to build this PR for Android and it failed in the configure: However, is better than in master branch. When trying to build the master branch, not even |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
conan-center-bot
added
the
Version conflict
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
conan-center-bot
removed
Failed
Version conflict
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 38 (
Conan v2 pipeline ✔️
All green in build 37 ( |
AbrilRBS
approved these changes
Sep 24, 2024
|
@AbrilRBS @uilianries @danimtb this PR breaks Windows builds by unconditionally requiring s2n package. All Windows builds report INVALID_CONFIGURATION now. |
|
@maksim-petukhov we are looking at it, thanks for your quick report. |
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
… new version and remove old one * [aws refactor] aws-sdk-cpp: Review dependencies, add new version and remove old one * patches * fix * fix * fix * fix * Add patches for new version * Fix missing patch * Fix crossbuildings, fix invalid macos invalidation, and dependant files copy * Reorder requirements to match upstream dependency declarations * Link Pulseaudio for Android * Add missing requires * Cleanup * Add missing requires * Fix component requires * Reorder for better checking in new versions in the future * Add zlib requirement, else compression fails when it finds it in the system * Fix pulseaudio dependency in Android * aws-sdk-cpp: add missing transitive_headers=True * Fix pulseaudio for non linux systems * backport pulseaudio to old version * Add AudioToolbox to text-to-speech frameworks * Validate build issue out * Fix * Cleanups * TypO * Final improvements for aws-sdk-cpp, sdks are now defined per-version * Back to validate() * Support Conan 1 * Back to validate_build() --------- Co-authored-by: Abril Rincón Blanco <[email protected]> Co-authored-by: Martin Valgur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #24831