Revert "Fix bugs related to printing types (#661)" #673
Conversation
This reverts commit f65f80a.
|
The native workflow is expected to fail as part of this PR, as it will also require reverting changes in cppyy repos to pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
- Coverage 79.25% 79.18% -0.07%
==========================================
Files 9 9
Lines 3866 3853 -13
==========================================
- Hits 3064 3051 -13
Misses 802 802
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| DefaultArgExpr = PI->getUninstantiatedDefaultArg(); | ||
| else | ||
| DefaultArgExpr = PI->getDefaultArg(); | ||
| Expr* DefaultArgExpr = const_cast<Expr*>(PI->getDefaultArg()); |
There was a problem hiding this comment.
warning: redundant explicit casting to the same type 'Expr *' as the sub-expression, remove this casting [readability-redundant-casting]
| Expr* DefaultArgExpr = const_cast<Expr*>(PI->getDefaultArg()); | |
| Expr* DefaultArgExpr = PI->getDefaultArg(); |
Additional context
llvm/include/clang/AST/Decl.h:1824: source type originates from the invocation of this method
Expr *getDefaultArg();
^
|
@vgvassilev @Vipul-Cariappa Despite this PR #657 being one commit behind main, and being able to pass the Emscripten workflow, my intuition turned out to be wrong, and reverting the commit will not fix main. The only solution which has shown to allow the Emscripten workflow to pass again is merging #655 (After clearing main of the Emscripten builds of llvm). |
Description
Please include a summary of changes, motivation and context for this PR.
This reverts commit f65f80a.
@vgvassilev To make the Emscripten workflow pass for all jobs again (and by extension allow our deployment workflow to work again), either this PR needs to go in (and revert any cppyy related PRs), or this one needs to go in #655, which fixes the Emscripten workflow without needing to revert the latest commit to CppInterOps main.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist