fix JITcall codegen to handle move semantics #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
+ Coverage 79.25% 79.30% +0.05%
==========================================
Files 9 9
Lines 3866 3876 +10
==========================================
+ Hits 3064 3074 +10
Misses 802 802
🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Jul 4, 2025
lib/CppInterOp/CppInterOp.cpp
Outdated
| // available, while there is a move constructor. | ||
|
|
||
| // move construction as needed for classes (note that this is implicit) | ||
| static bool included_utility = false; |
There was a problem hiding this comment.
I don't think this would work well when we have a stack of interpreters, that is changing the active interpreter. Perhaps a simple lookup will help, clang::Sema already getStdNamespace.
Vipul-Cariappa
force-pushed
the
dev/std-move
branch
2 times, most recently
from
b86e4a9 to
62c3217
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Vipul-Cariappa
force-pushed
the
dev/std-move
branch
from
62c3217 to
6b52e16
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
4 tasks
Vipul-Cariappa
force-pushed
the
dev/std-move
branch
2 times, most recently
from
725bb46 to
67ea645
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
This is also managing to fix the failing Emscripten job on main. No idea why. |
Required for std::unique_ptr Taken from Cling
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required for std::unique_ptr
Taken from Cling
Fixes # (issue)
1 test in cppyy
Type of change
Please tick all options which are relevant.
Testing
Checklist