From 0d7caad801c47121bd2a3eac8c53470088ede59c Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Tue, 5 Mar 2024 09:01:12 +1000 Subject: [PATCH 1/9] Updating next release version to be v2.6.1 --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5b04f57..bf5d9b3 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -32,7 +32,7 @@ option (UBLOX_BUILD_EXAMPLES "Build examples." OFF) # COMMSDSL2SWIG_EXTRA_ARGS - Extra arguments to pass to "commsdsl2swig" # COMMSDSL2EMSCRIPTEN_EXTRA_ARGS - Extra arguments to pass to "commsdsl2emscripten" -set (UBLOX_VERSION "2.6") +set (UBLOX_VERSION "2.6.1") set (UBLOX_MIN_COMMSDSL_VERSION "6.3") set (EXTERNALS_DIR "${PROJECT_SOURCE_DIR}/externals") From 007cb0e6653e411a70a05773a290f1ab67b53f38 Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Thu, 11 Apr 2024 08:57:02 +1000 Subject: [PATCH 2/9] Using latest releases of the dependencies in github actions and appveyor. * comms - v5.2.3 * commsdsl - v6.3.2 * cc_tools_qt - v5.2.1 --- .appveyor.yml | 12 ++++----- .github/workflows/actions_build.yml | 40 ++++++++++++++--------------- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/.appveyor.yml b/.appveyor.yml index 7725a68..10dc1b2 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -18,9 +18,9 @@ configuration: - Release environment: - COMMS_BRANCH: v5.2.2 - COMMSDSL_BRANCH: v6.3 - CC_TOOLS_QT_BRANCH: v5.1 + COMMS_TAG: v5.2.3 + COMMSDSL_TAG: v6.3.2 + CC_TOOLS_QT_TAG: v5.2.1 matrix: - CPP_STD: 11 QT_MAJOR: 5 @@ -46,9 +46,9 @@ install: - set PATH=%PATH%;%QTDIR%\bin - set BUILD_DIR=%APPVEYOR_BUILD_FOLDER%\build.%PLATFORM%.%CONFIGURATION%.%TOOLCHAIN% - if exist %BUILD_DIR% rmdir /S /Q %BUILD_DIR% - - set COMMS_TAG=%COMMS_BRANCH% - - set COMMSDSL_TAG=%COMMSDSL_BRANCH% - - set CC_TOOLS_QT_TAG=%CC_TOOLS_QT_BRANCH% + - set COMMS_TAG=%COMMS_TAG% + - set COMMSDSL_TAG=%COMMSDSL_TAG% + - set CC_TOOLS_QT_TAG=%CC_TOOLS_QT_TAG% - set COMMON_INSTALL_DIR=%BUILD_DIR%\install - set COMMON_BUILD_TYPE=%CONFIGURATION% - set COMMON_CXX_STANDARD=%CPP_STD% diff --git a/.github/workflows/actions_build.yml b/.github/workflows/actions_build.yml index 248a7c2..1cd4be6 100644 --- a/.github/workflows/actions_build.yml +++ b/.github/workflows/actions_build.yml @@ -3,9 +3,9 @@ name: Github Actions Build on: [push] env: - COMMS_BRANCH: v5.2.2 - COMMSDSL_BRANCH: v6.3 - CC_TOOLS_QT_BRANCH: v5.1 + COMMS_TAG: v5.2.3 + COMMSDSL_TAG: v6.3.2 + CC_TOOLS_QT_TAG: v5.2.1 jobs: build_gcc_old_ubuntu_20_04: @@ -47,8 +47,8 @@ jobs: COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install COMMON_BUILD_TYPE: ${{matrix.type}} COMMON_CXX_STANDARD: ${{matrix.cpp}} - COMMS_TAG: ${{env.COMMS_BRANCH}} - COMMSDSL_TAG: ${{env.COMMSDSL_BRANCH}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} CC_TOOLS_QT_SKIP: 1 - name: Configure CMake @@ -115,9 +115,9 @@ jobs: COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install COMMON_BUILD_TYPE: ${{matrix.type}} COMMON_CXX_STANDARD: ${{matrix.cpp}} - COMMS_TAG: ${{env.COMMS_BRANCH}} - COMMSDSL_TAG: ${{env.COMMSDSL_BRANCH}} - CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_BRANCH}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} + CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_TAG}} - name: Configure CMake shell: bash @@ -174,9 +174,9 @@ jobs: COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install COMMON_BUILD_TYPE: ${{matrix.type}} COMMON_CXX_STANDARD: ${{matrix.cpp}} - COMMS_TAG: ${{env.COMMS_BRANCH}} - COMMSDSL_TAG: ${{env.COMMSDSL_BRANCH}} - CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_BRANCH}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} + CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_TAG}} CC_TOOLS_QT_MAJOR_QT_VERSION: ${{matrix.qt_ver}} - name: Configure CMake @@ -244,9 +244,9 @@ jobs: COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install COMMON_BUILD_TYPE: ${{matrix.type}} COMMON_CXX_STANDARD: ${{matrix.cpp}} - COMMS_TAG: ${{env.COMMS_BRANCH}} - COMMSDSL_TAG: ${{env.COMMSDSL_BRANCH}} - CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_BRANCH}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} + CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_TAG}} - name: Configure CMake shell: bash @@ -306,9 +306,9 @@ jobs: COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install COMMON_BUILD_TYPE: ${{matrix.type}} COMMON_CXX_STANDARD: ${{matrix.cpp}} - COMMS_TAG: ${{env.COMMS_BRANCH}} - COMMSDSL_TAG: ${{env.COMMSDSL_BRANCH}} - CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_BRANCH}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} + CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_TAG}} CC_TOOLS_QT_SKIP: "${{ matrix.cpp < 17 && '1' || '0' }}" - name: Configure CMake @@ -366,9 +366,9 @@ jobs: COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install COMMON_BUILD_TYPE: ${{matrix.type}} COMMON_CXX_STANDARD: ${{matrix.cpp}} - COMMS_TAG: ${{env.COMMS_BRANCH}} - COMMSDSL_TAG: ${{env.COMMSDSL_BRANCH}} - CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_BRANCH}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} + CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_TAG}} CC_TOOLS_QT_MAJOR_QT_VERSION: ${{matrix.qt_ver}} CC_TOOLS_QT_SKIP: "${{ (matrix.cpp < 17 || (matrix.cpp == 20 && matrix.cc_ver < 15)) && '1' || '0' }}" From 03192593caccd42d6ed24e5665bc0177d656af6c Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Thu, 11 Apr 2024 08:58:31 +1000 Subject: [PATCH 3/9] Requiring v3.10 of cmake. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index bf5d9b3..0a12cf2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required (VERSION 3.5) +cmake_minimum_required (VERSION 3.10) project ("cc.ublox.commsdsl") option (UBLOX_NO_WARN_AS_ERR "Don't treat compilation warnings as errors." OFF) From 38fb0af24e37cf5574121a0120c5751e2d5fad72 Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Thu, 11 Apr 2024 08:58:53 +1000 Subject: [PATCH 4/9] Requiring v6.3.2 of commsdsl. --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 0a12cf2..2e002db 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -32,8 +32,8 @@ option (UBLOX_BUILD_EXAMPLES "Build examples." OFF) # COMMSDSL2SWIG_EXTRA_ARGS - Extra arguments to pass to "commsdsl2swig" # COMMSDSL2EMSCRIPTEN_EXTRA_ARGS - Extra arguments to pass to "commsdsl2emscripten" -set (UBLOX_VERSION "2.6.1") -set (UBLOX_MIN_COMMSDSL_VERSION "6.3") +set (UBLOX_VERSION "2.7") +set (UBLOX_MIN_COMMSDSL_VERSION "6.3.2") set (EXTERNALS_DIR "${PROJECT_SOURCE_DIR}/externals") From a3b47c4189f9368545d993a4d31204599d7e0447 Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Thu, 11 Apr 2024 09:05:12 +1000 Subject: [PATCH 5/9] Added windows runners to github. --- .github/workflows/actions_build.yml | 141 ++++++++++++++++++++++++++-- 1 file changed, 135 insertions(+), 6 deletions(-) diff --git a/.github/workflows/actions_build.yml b/.github/workflows/actions_build.yml index 1cd4be6..53caf98 100644 --- a/.github/workflows/actions_build.yml +++ b/.github/workflows/actions_build.yml @@ -18,7 +18,7 @@ jobs: cpp: [11] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Add repositories run: | @@ -86,7 +86,7 @@ jobs: - cc_ver: 7 cpp: 17 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Add repositories run: | @@ -150,7 +150,7 @@ jobs: qt_ver: [5, 6] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Prepare Install run: sudo apt-get update --fix-missing @@ -214,7 +214,7 @@ jobs: steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Add repositories run: | @@ -284,7 +284,7 @@ jobs: cpp: 20 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Prepare Install run: sudo apt-get update --fix-missing @@ -342,7 +342,7 @@ jobs: qt_ver: [5, 6] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Prepare Install run: sudo apt-get update --fix-missing @@ -392,3 +392,132 @@ jobs: run: cmake --build . --config ${{matrix.type}} --target install env: VERBOSE: 1 + + build_msvc_2019: + runs-on: windows-2019 + strategy: + fail-fast: false + matrix: + type: [Debug, Release, MinSizeRel] + arch: [Win32, x64] + cpp: [11, 14, 17] + qt_ver: [5, 6] + exclude: + - arch: Win32 + qt_ver: 6 + + steps: + - uses: actions/checkout@v4 + + - name: Create Build Environment + run: cmake -E make_directory ${{runner.workspace}}/build + + - name: Install Qt + if: ${{matrix.cpp >= 17 && matrix.arch == 'x64'}} + shell: cmd + run: | + choco install curl + curl -L https://github.com/martinrotter/qt-minimalistic-builds/releases/download/${{env.QT_VER}}/qt-${{env.QT_VER}}-dynamic-msvc2019-x86_64.7z -o ${{runner.workspace}}/qt.7z + 7z x ${{runner.workspace}}/qt.7z -o${{runner.workspace}}/qt + echo QT_VER=${{env.QT_VER}} >>%GITHUB_ENV% + echo QTDIR=${{runner.workspace}}/qt/qt-${{env.QT_VER}}-dynamic-msvc2019-x86_64 >>%GITHUB_ENV% + env: + QT_VER: ${{matrix.qt_ver == '5' && '5.15.3' || '6.2.2'}} + + - name: Install Boost + shell: cmd + run: | + choco install boost-msvc-14.2 + + - name: Prepare externals + shell: cmd + run: | + %GITHUB_WORKSPACE%\script\prepare_externals.bat + env: + BUILD_DIR: ${{runner.workspace}}/build + PLATFORM: ${{matrix.arch}} + EXTERNALS_DIR: ${{runner.workspace}}/externals + COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install + COMMON_BUILD_TYPE: ${{matrix.type}} + COMMON_CXX_STANDARD: ${{matrix.cpp}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} + COMMSDSL_PLATFORM: 'x64' + CC_TOOLS_QT_TAG: ${{env.CC_TOOLS_QT_TAG}} + CC_TOOLS_QT_MAJOR_QT_VERSION: ${{matrix.qt_ver}} + CC_TOOLS_QT_SKIP: ${{matrix.arch == 'Win32' && '1' || '0'}} + + - name: Configure CMake + shell: cmd + working-directory: ${{runner.workspace}}/build + run: | + cmake %GITHUB_WORKSPACE% -A ${{matrix.arch}} -DCMAKE_BUILD_TYPE=${{matrix.type}} -DCMAKE_INSTALL_PREFIX=install ^ + -DCMAKE_PREFIX_PATH="${{runner.workspace}}/build/install;${{env.QTDIR}}" -DBoost_USE_STATIC_LIBS=ON ^ + -DCMAKE_CXX_STANDARD=${{matrix.cpp}} -DUBLOX_TOOLS_QT_VER=${{matrix.qt_ver}} ^ + -DUBLOX_GEN_PROTOCOL=ON -DUBLOX_GEN_TEST=ON -DUBLOX_GEN_TOOLS=ON -DUBLOX_BUILD_TOOLS=${{env.BUILD_TOOLS}} ^ + -DUBLOX_SCHEMA_FILES_LIST_FILE=%GITHUB_WORKSPACE%/basic_msgs.txt + env: + BUILD_TOOLS: "${{ matrix.cpp >= 17 && matrix.arch == 'x64' && 'ON' || 'OFF' }}" + + - name: Build Target + working-directory: ${{runner.workspace}}/build + shell: cmd + run: cmake --build . --config ${{matrix.type}} --target install + env: + VERBOSE: 1 + + build_msvc_2022: + runs-on: windows-2022 + strategy: + fail-fast: false + matrix: + type: [Debug, Release, MinSizeRel] + arch: [Win32, x64] + cpp: [11, 14, 17, 20] + + steps: + - uses: actions/checkout@v4 + + - name: Create Build Environment + run: cmake -E make_directory ${{runner.workspace}}/build + + - name: Install Boost + if: matrix.arch == 'x64' + shell: cmd + run: | + choco install boost-msvc-14.3 + + - name: Prepare externals + shell: cmd + run: | + %GITHUB_WORKSPACE%\script\prepare_externals.bat + env: + BUILD_DIR: ${{runner.workspace}}/build + PLATFORM: ${{matrix.arch}} + EXTERNALS_DIR: ${{runner.workspace}}/externals + COMMON_INSTALL_DIR: ${{runner.workspace}}/build/install + COMMON_BUILD_TYPE: ${{matrix.type}} + COMMON_CXX_STANDARD: ${{matrix.cpp}} + COMMS_TAG: ${{env.COMMS_TAG}} + COMMSDSL_TAG: ${{env.COMMSDSL_TAG}} + COMMSDSL_PLATFORM: 'x64' + CC_TOOLS_QT_SKIP: 1 + + - name: Configure CMake + shell: cmd + working-directory: ${{runner.workspace}}/build + run: | + cmake %GITHUB_WORKSPACE% -A ${{matrix.arch}} -DCMAKE_BUILD_TYPE=${{matrix.type}} -DCMAKE_INSTALL_PREFIX=install ^ + -DCMAKE_PREFIX_PATH="${{runner.workspace}}/build/install" -DBoost_USE_STATIC_LIBS=ON ^ + -DCMAKE_CXX_STANDARD=${{matrix.cpp}} -DUBLOX_TOOLS_QT_VER=${{matrix.qt_ver}} ^ + -DUBLOX_GEN_PROTOCOL=ON -DUBLOX_GEN_TEST=ON -DUBLOX_BUILD_EXAMPLES=${{env.HAS_BOOST}} ^ + -DUBLOX_SCHEMA_FILES_LIST_FILE=%GITHUB_WORKSPACE%/basic_msgs.txt + env: + HAS_BOOST: "${{ matrix.arch == 'x64' && 'ON' || 'OFF' }}" + + - name: Build Target + working-directory: ${{runner.workspace}}/build + shell: cmd + run: cmake --build . --config ${{matrix.type}} + env: + VERBOSE: 1 From c47a4388c2a0ad46bf53188dd785452ed2dc7ecb Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Thu, 11 Apr 2024 15:55:43 +1000 Subject: [PATCH 6/9] Fixing prepare_externals.bat --- script/prepare_externals.bat | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/script/prepare_externals.bat b/script/prepare_externals.bat index eef97cf..2f5a8f2 100755 --- a/script/prepare_externals.bat +++ b/script/prepare_externals.bat @@ -8,9 +8,11 @@ rem COMMS_REPO - (Optional) Repository of the COMMS library rem COMMS_TAG - (Optional) Tag of the COMMS library rem COMMSDSL_REPO - (Optional) Repository of the commsdsl code generators rem COMMSDSL_TAG - (Optional) Tag of the commdsl +rem COMMSDSL_PLATFORM - (Optional) Tag of the commdsl rem CC_TOOLS_QT_REPO - (Optional) Repository of the cc_tools_qt rem CC_TOOLS_QT_TAG - (Optional) Tag of the cc_tools_qt rem CC_TOOLS_QT_MAJOR_QT_VERSION - (Optional) Major version of the Qt library +rem CC_TOOLS_QT_SKIP - (Optional) Skip build of cc_tools_qt rem COMMON_INSTALL_DIR - (Optional) Common directory to perform installations rem COMMON_BUILD_TYPE - (Optional) CMake build type rem COMMON_CXX_STANDARD - (Optional) CMake C++ standard @@ -19,7 +21,7 @@ rem ----------------------------------------------------- if [%BUILD_DIR%] == [] echo "BUILD_DIR hasn't been specified" & exit /b 1 -if [%GENERATOR%] == [] set GENERATOR="NMake Makefiles" +if NOT [%GENERATOR%] == [] set GENERATOR_PARAM=-G %GENERATOR% if NOT [%PLATFORM%] == [] set PLATFORM_PARAM=-A %PLATFORM% @@ -33,6 +35,9 @@ if [%COMMSDSL_REPO%] == [] set COMMSDSL_REPO="https://github.com/commschamp/comm if [%COMMSDSL_TAG%] == [] set COMMSDSL_TAG="master" +set COMMSDSL_PLATFORM_PARAM=%PLATFORM_PARAM% +if NOT [%COMMSDSL_PLATFORM%] == [] set COMMSDSL_PLATFORM_PARAM=-A %COMMSDSL_PLATFORM% + if [%CC_TOOLS_QT_REPO%] == [] set CC_TOOLS_QT_REPO="https://github.com/commschamp/cc_tools_qt.git" if [%CC_TOOLS_QT_TAG%] == [] set CC_TOOLS_QT_TAG="master" @@ -76,7 +81,7 @@ if exist %COMMS_SRC_DIR%/.git ( echo "Building COMMS library..." mkdir "%COMMS_BUILD_DIR%" cd %COMMS_BUILD_DIR% -cmake -G %GENERATOR% %PLATFORM_PARAM% -S %COMMS_SRC_DIR% -B %COMMS_BUILD_DIR% -DCMAKE_INSTALL_PREFIX=%COMMS_INSTALL_DIR% ^ +cmake %GENERATOR_PARAM% %PLATFORM_PARAM% -S %COMMS_SRC_DIR% -B %COMMS_BUILD_DIR% -DCMAKE_INSTALL_PREFIX=%COMMS_INSTALL_DIR% ^ -DCMAKE_BUILD_TYPE=%COMMON_BUILD_TYPE% -DCMAKE_CXX_STANDARD=%COMMON_CXX_STANDARD% if %errorlevel% neq 0 exit /b %errorlevel% cmake --build %COMMS_BUILD_DIR% --config %COMMON_BUILD_TYPE% --target install @@ -100,7 +105,7 @@ if exist %COMMSDSL_SRC_DIR%/.git ( echo "Building commsdsl ..." mkdir "%COMMSDSL_BUILD_DIR%" cd %COMMSDSL_BUILD_DIR% -cmake -G %GENERATOR% %PLATFORM_PARAM% -S %COMMSDSL_SRC_DIR% -B %COMMSDSL_BUILD_DIR% ^ +cmake %GENERATOR_PARAM% %COMMSDSL_PLATFORM_PARAM% -S %COMMSDSL_SRC_DIR% -B %COMMSDSL_BUILD_DIR% ^ -DCMAKE_INSTALL_PREFIX=%COMMSDSL_INSTALL_DIR% -DCMAKE_BUILD_TYPE=%COMMON_BUILD_TYPE% ^ -DCOMMSDSL_INSTALL_LIBRARY=OFF -DCOMMSDSL_BUILD_COMMSDSL2TEST=ON -DCOMMSDSL_BUILD_COMMSDSL2TOOLS_QT=ON if %errorlevel% neq 0 exit /b %errorlevel% @@ -114,6 +119,11 @@ if %COMMON_CXX_STANDARD% LSS 17 ( goto cc_tools_qt_end ) +if %CC_TOOLS_QT_SKIP% GTR 0 ( + echo "Skipping build of cc_tools_qt" + goto cc_tools_qt_end +) + if exist %CC_TOOLS_QT_SRC_DIR%/.git ( echo "Updating cc_tools_qt..." cd %CC_TOOLS_QT_SRC_DIR% @@ -130,7 +140,7 @@ if exist %CC_TOOLS_QT_SRC_DIR%/.git ( echo "Building cc_tools_qt ..." mkdir "%CC_TOOLS_QT_BUILD_DIR%" cd %CC_TOOLS_QT_BUILD_DIR% -cmake -G %GENERATOR% %PLATFORM_PARAM% -S %CC_TOOLS_QT_SRC_DIR% -B %CC_TOOLS_QT_BUILD_DIR% ^ +cmake %GENERATOR_PARAM% %PLATFORM_PARAM% -S %CC_TOOLS_QT_SRC_DIR% -B %CC_TOOLS_QT_BUILD_DIR% ^ -DCMAKE_INSTALL_PREFIX=%CC_TOOLS_QT_INSTALL_DIR% -DCMAKE_BUILD_TYPE=%COMMON_BUILD_TYPE% ^ -DCC_TOOLS_QT_BUILD_APPS=OFF -DCMAKE_PREFIX_PATH=%COMMS_INSTALL_DIR%;%QTDIR% ^ -DCMAKE_CXX_STANDARD=%COMMON_CXX_STANDARD% %CC_TOOLS_QT_VERSION_OPT% From 9e9ddab9c859fbc46cab0f568ccfae6b88718d83 Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Fri, 12 Apr 2024 07:51:14 +1000 Subject: [PATCH 7/9] Attempt to fix build with windows-2019 runner on github actions. --- .github/workflows/actions_build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/actions_build.yml b/.github/workflows/actions_build.yml index 53caf98..ad8b262 100644 --- a/.github/workflows/actions_build.yml +++ b/.github/workflows/actions_build.yml @@ -455,6 +455,7 @@ jobs: -DCMAKE_PREFIX_PATH="${{runner.workspace}}/build/install;${{env.QTDIR}}" -DBoost_USE_STATIC_LIBS=ON ^ -DCMAKE_CXX_STANDARD=${{matrix.cpp}} -DUBLOX_TOOLS_QT_VER=${{matrix.qt_ver}} ^ -DUBLOX_GEN_PROTOCOL=ON -DUBLOX_GEN_TEST=ON -DUBLOX_GEN_TOOLS=ON -DUBLOX_BUILD_TOOLS=${{env.BUILD_TOOLS}} ^ + -DUBLOX_BUILD_EXAMPLES=ON ^ -DUBLOX_SCHEMA_FILES_LIST_FILE=%GITHUB_WORKSPACE%/basic_msgs.txt env: BUILD_TOOLS: "${{ matrix.cpp >= 17 && matrix.arch == 'x64' && 'ON' || 'OFF' }}" @@ -462,7 +463,7 @@ jobs: - name: Build Target working-directory: ${{runner.workspace}}/build shell: cmd - run: cmake --build . --config ${{matrix.type}} --target install + run: cmake --build . --config ${{matrix.type}} env: VERBOSE: 1 From 52ac2169a37c032bd6e23ac514d74ee6732344ba Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Fri, 12 Apr 2024 07:52:55 +1000 Subject: [PATCH 8/9] Temporarily disabling non windows-2019 runners on github actions. --- .github/workflows/actions_build.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/actions_build.yml b/.github/workflows/actions_build.yml index ad8b262..6a29563 100644 --- a/.github/workflows/actions_build.yml +++ b/.github/workflows/actions_build.yml @@ -9,6 +9,7 @@ env: jobs: build_gcc_old_ubuntu_20_04: + if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -71,6 +72,7 @@ jobs: VERBOSE: 1 build_gcc_ubuntu_20_04: + if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -140,6 +142,7 @@ jobs: VERBOSE: 1 build_gcc_ubuntu_22_04: + if: false runs-on: ubuntu-22.04 strategy: fail-fast: false @@ -201,6 +204,7 @@ jobs: VERBOSE: 1 build_clang_old_ubuntu_20_04: + if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -270,6 +274,7 @@ jobs: VERBOSE: 1 build_clang_ubuntu_20_04: + if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -332,6 +337,7 @@ jobs: VERBOSE: 1 build_clang_ubuntu_22_04: + if: false runs-on: ubuntu-22.04 strategy: fail-fast: false @@ -468,6 +474,7 @@ jobs: VERBOSE: 1 build_msvc_2022: + if: false runs-on: windows-2022 strategy: fail-fast: false From 40c340b3dfd2caacf303cc76bf1a2bb55ba63b36 Mon Sep 17 00:00:00 2001 From: Alex Robenko Date: Fri, 12 Apr 2024 08:03:51 +1000 Subject: [PATCH 9/9] Revert "Temporarily disabling non windows-2019 runners on github actions." This reverts commit 52ac2169a37c032bd6e23ac514d74ee6732344ba. --- .github/workflows/actions_build.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/actions_build.yml b/.github/workflows/actions_build.yml index 6a29563..ad8b262 100644 --- a/.github/workflows/actions_build.yml +++ b/.github/workflows/actions_build.yml @@ -9,7 +9,6 @@ env: jobs: build_gcc_old_ubuntu_20_04: - if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -72,7 +71,6 @@ jobs: VERBOSE: 1 build_gcc_ubuntu_20_04: - if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -142,7 +140,6 @@ jobs: VERBOSE: 1 build_gcc_ubuntu_22_04: - if: false runs-on: ubuntu-22.04 strategy: fail-fast: false @@ -204,7 +201,6 @@ jobs: VERBOSE: 1 build_clang_old_ubuntu_20_04: - if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -274,7 +270,6 @@ jobs: VERBOSE: 1 build_clang_ubuntu_20_04: - if: false runs-on: ubuntu-20.04 strategy: fail-fast: false @@ -337,7 +332,6 @@ jobs: VERBOSE: 1 build_clang_ubuntu_22_04: - if: false runs-on: ubuntu-22.04 strategy: fail-fast: false @@ -474,7 +468,6 @@ jobs: VERBOSE: 1 build_msvc_2022: - if: false runs-on: windows-2022 strategy: fail-fast: false