From 7fab238b1026e349f467f99d95730fa4cc91c3a3 Mon Sep 17 00:00:00 2001 From: Airyzz <36567925+Airyzz@users.noreply.github.com> Date: Sun, 2 Jun 2024 17:58:58 +0930 Subject: [PATCH] test measuring timeline event widget build count --- commet/lib/ui/molecules/timeline_event.dart | 4 +++ commet/test_driver/benchmark_driver.dart | 31 ++++----------------- 2 files changed, 10 insertions(+), 25 deletions(-) diff --git a/commet/lib/ui/molecules/timeline_event.dart b/commet/lib/ui/molecules/timeline_event.dart index 1237c5ca..9aeb7a5c 100644 --- a/commet/lib/ui/molecules/timeline_event.dart +++ b/commet/lib/ui/molecules/timeline_event.dart @@ -46,6 +46,8 @@ class TimelineEventView extends StatefulWidget { final bool canDeleteEvent; final Function(Emoticon emote)? onReactionTapped; + static int timelineEventBuildsCount = 0; + @override State createState() => _TimelineEventState(); } @@ -212,6 +214,8 @@ class _TimelineEventState extends State { @override Widget build(BuildContext context) { + TimelineEventView.timelineEventBuildsCount += 1; + return eventToWidget(widget.event) ?? Container(); } diff --git a/commet/test_driver/benchmark_driver.dart b/commet/test_driver/benchmark_driver.dart index 6cc017fc..9e702a2a 100644 --- a/commet/test_driver/benchmark_driver.dart +++ b/commet/test_driver/benchmark_driver.dart @@ -1,5 +1,6 @@ // ignore_for_file: depend_on_referenced_packages +import 'package:commet/ui/molecules/timeline_event.dart'; import 'package:flutter_driver/flutter_driver.dart'; import 'dart:convert' show JsonEncoder; @@ -21,6 +22,11 @@ Future main() { final summary = TimelineSummary.summarize(timeline); result.addAll([ + { + "name": "Timeline Widget Build Count", + "value": TimelineEventView.timelineEventBuildsCount, + "unit": "Builds" + }, { "name": "$key - Average Build Time", "value": summary.computeAverageFrameBuildTimeMillis(), @@ -67,31 +73,6 @@ Future main() { "value": summary.computePercentileFrameRasterizerTimeMillis(50), "unit": "ms" }, - { - "name": "$key - Frames missed build budget", - "value": summary.computeMissedFrameBuildBudgetCount(), - "unit": "Frames" - }, - { - "name": "$key - Frame Count", - "value": summary.countFrames(), - "unit": "Frames" - }, - { - "name": "$key - Raster Count", - "value": summary.countRasterizations(), - "unit": "Rasterizations" - }, - { - "name": "$key - New generation garbage collections", - "value": summary.newGenerationGarbageCollections(), - "unit": "Collections" - }, - { - "name": "$key - Old generation garbage collections", - "value": summary.oldGenerationGarbageCollections(), - "unit": "Collections" - }, ]); }