Rewrite Timeline View to improve performance (#258)

Author: Airyzz

commet/lib/client/components/push_notification/android/firebase_push_notifier.dart

@@ -32,7 +32,7 @@ Future<void> onForegroundMessage(dynamic message) async {
   var room = client.getRoom(roomId);
   var event = await room!.getEvent(eventId);
 
-  var user = room.getMemberOrFallback(event!.senderId)!;
+  var user = room.getMemberOrFallback(event!.senderId);
 
   Log.i("Dispatching notification");
 

commet/lib/client/components/push_notification/android/unified_push_notifier.dart

@@ -99,7 +99,7 @@ class UnifiedPushNotifier implements Notifier {
     var room = client.getRoom(roomId);
     var event = await room!.getEvent(eventId);
 
-    var user = room.getMemberOrFallback(event!.senderId)!;
+    var user = room.getMemberOrFallback(event!.senderId);
 
     NotificationManager.notify(MessageNotificationContent(
         senderName: user.displayName,

commet/lib/client/matrix/components/url_preview/matrix_url_preview_component.dart

@@ -6,9 +6,11 @@ import 'package:commet/client/room.dart';
 import 'package:commet/client/timeline.dart';
 import 'package:commet/debug/log.dart';
 import 'package:commet/main.dart';
+import 'package:commet/utils/mime.dart';
 import 'package:flutter/widgets.dart';
 import 'package:matrix/matrix.dart' as matrix;
 import 'package:encrypted_url_preview/encrypted_url_preview.dart';
+import 'package:matrix/matrix_api_lite.dart';
 
 class MatrixUrlPreviewComponent implements UrlPreviewComponent<MatrixClient> {
   @override
@@ -20,6 +22,8 @@ class MatrixUrlPreviewComponent implements UrlPreviewComponent<MatrixClient> {
 
   EncryptedUrlPreview? privatePreviewGetter;
 
+  bool? serverSupportsUrlPreview;
+
   void createPrivatePreviewGetter() {
     privatePreviewGetter = EncryptedUrlPreview(
         proxyServerUrl: Uri.https("telescope.commet.chat"),
@@ -62,7 +66,10 @@ pQIDAQAB
       return null;
     }
 
-    cache[uri.toString()] = data!;
+    if (data != null) {
+      cache[uri.toString()] = data;
+    }
+
     return data;
   }
 
@@ -82,6 +89,10 @@ pQIDAQAB
       return false;
     }
 
+    if (serverSupportsUrlPreview == false) {
+      return false;
+    }
+
     return event.links?.isNotEmpty == true;
   }
 
@@ -137,20 +148,46 @@ pQIDAQAB
 
   Future<UrlPreviewData?> fetchPreviewData(
       matrix.Client client, Uri url) async {
-    var response = await client.request(
-        matrix.RequestType.GET, "/media/v3/preview_url",
-        query: {"url": url.toString()});
+    late Map<String, Object?> response;
+    try {
+      response = await client.request(
+          matrix.RequestType.GET, "/media/v3/preview_url",
+          query: {"url": url.toString()});
+    } catch (e, s) {
+      if (e is MatrixException) {
+        if (e.error == MatrixError.M_UNRECOGNIZED) {
+          serverSupportsUrlPreview = false;
+        }
+      }
+
+      Log.onError(e, s);
+
+      return null;
+    }
 
+    serverSupportsUrlPreview = true;
     var title = response['og:title'] as String?;
     var siteName = response['og:site_name'] as String?;
     var imageUrl = response['og:image'] as String?;
     var description = response['og:description'] as String?;
 
+    var type = response["og:image:type"] as String?;
+    if (type != null) {
+      if (Mime.displayableTypes.contains(type) == false) {
+        imageUrl = null;
+      }
+    }
+
     ImageProvider? image;
     if (imageUrl != null) {
       var imageUri = Uri.parse(imageUrl);
       if (imageUri.scheme == "mxc") {
-        image = MatrixMxcImage(imageUri, client, doThumbnail: false);
+        try {
+          image = MatrixMxcImage(imageUri, client, doThumbnail: false);
+        } catch (exception, stack) {
+          Log.onError(exception, stack);
+          Log.w("Failed to get mxc image");
+        }
       }
     }
 

commet/lib/client/matrix/matrix_client.dart

@@ -65,10 +65,6 @@ class MatrixClient extends Client {
       : matrix.NativeImplementationsIsolate(compute);
 
   MatrixClient({required String identifier}) {
-    if (preferences.developerMode) {
-      matrix.Logs().level = matrix.Level.verbose;
-    }
-
     _id = identifier;
     _matrixClient = _createMatrixClient(identifier);
     _matrixClient.onSync.stream.listen(onMatrixClientSync);
@@ -231,7 +227,6 @@ class MatrixClient extends Client {
   }
 
   void onMatrixClientSync(matrix.SyncUpdate update) {
-    Log.d("On Matrix Sync!");
     _onSync.add(null);
     _updateRoomslist();
     _updateSpacesList();
@@ -257,8 +252,6 @@ class MatrixClient extends Client {
       legacyDatabaseBuilder: (client) =>
           getLegacyMatrixDatabase(client.clientName),
       databaseBuilder: (client) => getMatrixDatabase(client.clientName),
-      logLevel:
-          BuildConfig.RELEASE ? matrix.Level.warning : matrix.Level.verbose,
     );
 
     client.onSyncStatus.stream.listen(onSyncStatusChanged);

commet/lib/client/matrix/matrix_room.dart

@@ -179,10 +179,13 @@ class MatrixRoom extends Room {
       }
     }
 
-    _onUpdateSubscription =
-        _matrixRoom.onUpdate.stream.listen(onMatrixRoomUpdate);
+    _onUpdateSubscription = _matrixRoom.client.onRoomState.stream
+        .where((event) => event.roomId == _matrixRoom.id)
+        .listen(onRoomStateUpdated);
 
-    _matrixRoom.client.onEvent.stream.listen(onEvent);
+    _matrixRoom.client.onEvent.stream
+        .where((event) => event.roomID == _matrixRoom.id)
+        .listen(onEvent);
 
     _permissions = MatrixRoomPermissions(_matrixRoom);
   }
@@ -238,10 +241,6 @@ class MatrixRoom extends Room {
 
     var sender = getMemberOrFallback(event.senderId);
 
-    if (sender == null) {
-      return;
-    }
-
     var notification = MessageNotificationContent(
         senderName: sender.displayName,
         senderId: sender.identifier,
@@ -371,9 +370,11 @@ class MatrixRoom extends Room {
     await _matrixRoom.enableEncryption();
   }
 
-  void onMatrixRoomUpdate(String event) async {
+  void onRoomStateUpdated(matrix.Event event) async {
     _displayName = _matrixRoom.getLocalizedDisplayname();
-    _onUpdate.add(null);
+    if (event.type == "m.room.name") {
+      _onUpdate.add(null);
+    }
   }
 
   @override
@@ -509,7 +510,7 @@ class MatrixRoom extends Room {
   bool get isMembersListComplete => _matrixRoom.participantListComplete;
 
   @override
-  Member? getMemberOrFallback(String id) {
+  Member getMemberOrFallback(String id) {
     return MatrixMember(
         _matrixRoom.client, _matrixRoom.unsafeGetUserFromMemoryOrFallback(id));
   }
@@ -522,9 +523,8 @@ class MatrixRoom extends Room {
     var roles = (state.content["users"] as Map<String, dynamic>);
     var ids = roles.keys;
 
-    var result = ids
-        .map((e) => (getMemberOrFallback(e)!, MatrixRole(roles[e])))
-        .toList();
+    var result =
+        ids.map((e) => (getMemberOrFallback(e), MatrixRole(roles[e]))).toList();
 
     result.removeWhere((element) => element.$2.rank == 0);
 

commet/lib/client/matrix/matrix_timeline_event.dart

@@ -256,7 +256,11 @@ class MatrixTimelineEvent implements TimelineEvent {
   }
 
   @override
-  Widget buildFormattedContent() {
+  Widget? buildFormattedContent() {
+    if (formattedBody == null) {
+      return null;
+    }
+
     return MatrixHtmlParser.parse(formattedBody!, event.room.client);
   }
 

commet/lib/client/room.dart

@@ -142,7 +142,7 @@ abstract class Room {
 
   Future<TimelineEvent?> getEvent(String eventId);
 
-  Member? getMemberOrFallback(String id);
+  Member getMemberOrFallback(String id);
 
   @override
   bool operator ==(Object other) {

commet/lib/client/timeline.dart

@@ -106,7 +106,7 @@ abstract class TimelineEvent {
   /// If you want to display the same message twice, use `buildFormattedContent()` to create a new widget
   Widget? get formattedContent;
 
-  Widget buildFormattedContent();
+  Widget? buildFormattedContent();
 
   String? get relatedEventId;
   String? get stateKey;

commet/lib/service/background_service_notifications/background_service_task_notification.dart

@@ -102,7 +102,7 @@ class BackgroundNotificationsManager {
     Log.i("Found room: ${room?.displayName}");
 
     var event = await room!.getEvent(eventId);
-    var user = room.getMemberOrFallback(event!.senderId)!;
+    var user = room.getMemberOrFallback(event!.senderId);
 
     Log.i("Got user: $user  ($user)");
     Log.i("Got event: ${event.body}");

commet/lib/ui/atoms/emoji_reaction.dart

@@ -20,7 +20,7 @@ class EmojiReaction extends StatelessWidget {
   final int numReactions;
   final bool highlighted;
 
-  BorderRadius get borderRadius => BorderRadius.circular(12);
+  BorderRadius get borderRadius => BorderRadius.circular(8);
 
   @override
   Widget build(BuildContext context) {