Skip to content

Commit 3695ff5

Browse files
committed
Consistent imports for NonEmpty
1 parent dee421d commit 3695ff5

File tree

9 files changed

+28
-25
lines changed

9 files changed

+28
-25
lines changed

src/Stack/Build.hs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,14 @@ module Stack.Build
1616
import Data.Attoparsec.Args ( EscapingMode (Escaping), parseArgs )
1717
import Data.List ( (\\) )
1818
import Data.List.Extra ( groupSort )
19-
import qualified Data.List.NonEmpty as NE
2019
import qualified Data.Map as Map
2120
import qualified Data.Set as Set
2221
import qualified Data.Text as T
2322
import qualified Distribution.PackageDescription as C
2423
import Distribution.Types.Dependency ( Dependency (..), depLibraries )
2524
import Distribution.Version ( mkVersion )
25+
import RIO.NonEmpty ( nonEmpty )
26+
import qualified RIO.NonEmpty as NE
2627
import Stack.Build.ConstructPlan ( constructPlan )
2728
import Stack.Build.Execute ( executePlan, preFetch, printPlan )
2829
import Stack.Build.Installed ( getInstalled, toInstallMap )
@@ -291,7 +292,7 @@ warnIfExecutablesWithSameNameCouldBeOverwritten locals plan = do
291292
, exe <- Set.toList (packageExes pkg)
292293
]
293294
collect :: Ord k => [(k, v)] -> Map k (NonEmpty v)
294-
collect = Map.mapMaybe NE.nonEmpty . Map.fromDistinctAscList . groupSort
295+
collect = Map.mapMaybe nonEmpty . Map.fromDistinctAscList . groupSort
295296

296297
warnAboutSplitObjs :: HasTerm env => BuildOpts -> RIO env ()
297298
warnAboutSplitObjs bopts | boptsSplitObjs bopts =

src/Stack/Build/Execute.hs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ import qualified Data.Conduit.List as CL
4343
import Data.Conduit.Process.Typed ( createSource )
4444
import qualified Data.Conduit.Text as CT
4545
import qualified Data.List as L
46-
import Data.List.NonEmpty ( nonEmpty )
47-
import qualified Data.List.NonEmpty as NonEmpty
4846
import Data.List.Split ( chunksOf )
4947
import qualified Data.Map.Merge.Strict as Map
5048
import qualified Data.Map.Strict as Map
@@ -81,6 +79,8 @@ import Path.IO
8179
, ignoringAbsence, removeDirRecur, removeFile, renameDir
8280
, renameFile
8381
)
82+
import RIO.NonEmpty ( nonEmpty )
83+
import qualified RIO.NonEmpty as NE
8484
import RIO.Process
8585
( HasProcessContext, byteStringInput, eceExitCode
8686
, findExecutable, getStderr, getStdout, inherit
@@ -922,7 +922,7 @@ unregisterPackages cv localDB ids = do
922922
let batchSize = case platform of
923923
Platform _ Windows -> 100
924924
_ -> 500
925-
let chunksOfNE size = mapMaybe nonEmpty . chunksOf size . NonEmpty.toList
925+
let chunksOfNE size = mapMaybe nonEmpty . chunksOf size . NE.toList
926926
for_ (chunksOfNE batchSize ids) $ \batch -> do
927927
for_ batch $ \(_, (ident, reason)) -> logReason ident reason
928928
pkg <- getGhcPkgExe

src/Stack/BuildPlan.hs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ module Stack.BuildPlan
1919

2020
import qualified Data.Foldable as F
2121
import Data.List (intercalate)
22-
import qualified Data.List.NonEmpty as NonEmpty
2322
import qualified Data.Map as Map
2423
import qualified Data.Set as Set
2524
import qualified Data.Text as T
@@ -34,6 +33,7 @@ import Distribution.Text ( display )
3433
import Distribution.Types.UnqualComponentName
3534
( unUnqualComponentName )
3635
import qualified Distribution.Version as C
36+
import qualified RIO.NonEmpty as NE
3737
import Stack.Constants ( wiredInPackages )
3838
import Stack.Package
3939
( PackageConfig (..), packageDependencies
@@ -221,7 +221,7 @@ selectPackageBuildPlan ::
221221
-> GenericPackageDescription
222222
-> (Map PackageName (Map FlagName Bool), DepErrors)
223223
selectPackageBuildPlan platform compiler pool gpd =
224-
(selectPlan . limitSearchSpace . NonEmpty.map makePlan) flagCombinations
224+
(selectPlan . limitSearchSpace . NE.map makePlan) flagCombinations
225225
where
226226
selectPlan :: NonEmpty (a, DepErrors) -> (a, DepErrors)
227227
selectPlan = F.foldr1 fewerErrors
@@ -410,11 +410,11 @@ selectBestSnapshot pkgDirs snaps = do
410410
prettyInfo $
411411
fillSep
412412
[ flow "Selecting the best among"
413-
, fromString $ show (NonEmpty.length snaps)
413+
, fromString $ show (NE.length snaps)
414414
, "snapshots..."
415415
]
416416
<> line
417-
F.foldr1 go (NonEmpty.map (getResult <=< snapshotLocation) snaps)
417+
F.foldr1 go (NE.map (getResult <=< snapshotLocation) snaps)
418418
where
419419
go mold mnew = do
420420
old@(_snap, _loc, bpc) <- mold

src/Stack/CLI.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import Options.Applicative.Builder.Extra
1717
( boolFlags, extraHelpOption, textOption )
1818
import Options.Applicative.Complicated
1919
( addCommand, addSubCommands, complicatedOptions )
20-
import qualified RIO.NonEmpty as NE
2120
import RIO.NonEmpty ( (<|) )
21+
import qualified RIO.NonEmpty as NE
2222
import qualified RIO.Process ( exec )
2323
import RIO.Process ( withProcessContextNoLogging )
2424
import Stack.Build ( buildCmd )

src/Stack/ConfigCmd.hs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import Data.Attoparsec.Text as P
2222
, takeWhile
2323
)
2424
import qualified Data.Map.Merge.Strict as Map
25-
import qualified Data.List.NonEmpty as NE
2625
import qualified Data.Text as T
2726
import qualified Data.Yaml as Yaml
2827
import qualified Options.Applicative as OA
@@ -31,6 +30,8 @@ import qualified Options.Applicative.Types as OA
3130
import Pantry ( loadSnapshot )
3231
import Path ( (</>), parent )
3332
import qualified RIO.Map as Map
33+
import RIO.NonEmpty ( nonEmpty )
34+
import qualified RIO.NonEmpty as NE
3435
import RIO.Process ( envVarsL )
3536
import Stack.Config
3637
( makeConcreteResolver, getProjectConfig
@@ -131,7 +132,7 @@ cfgCmdSet cmd = do
131132
-- key3: value
132133
--
133134
writeLines yamlLines spaces cmdKeys value =
134-
case NE.nonEmpty $ NE.tail cmdKeys of
135+
case nonEmpty $ NE.tail cmdKeys of
135136
Nothing -> yamlLines <> [spaces <> NE.head cmdKeys <> ": " <> value]
136137
Just ks -> writeLines
137138
(yamlLines <> [spaces <> NE.head cmdKeys <> ":"])
@@ -143,7 +144,7 @@ cfgCmdSet cmd = do
143144
Yaml.Object obj ->
144145
case KeyMap.lookup (Key.fromText (NE.head cmdKeys)) obj of
145146
Nothing -> Nothing
146-
Just v' -> case NE.nonEmpty $ NE.tail cmdKeys of
147+
Just v' -> case nonEmpty $ NE.tail cmdKeys of
147148
Nothing -> Just v'
148149
Just ks -> inConfig v' ks
149150
_ -> Nothing

src/Stack/Ghci.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import qualified Data.ByteString.Char8 as S8
1818
import qualified Data.ByteString.Lazy as LBS
1919
import qualified Data.List as L
2020
import Data.List.Extra ( (!?) )
21-
import qualified Data.List.NonEmpty as NE
2221
import qualified Data.Map.Strict as M
2322
import qualified Data.Set as S
2423
import qualified Data.Text as T
@@ -29,6 +28,7 @@ import Path ((</>), parent, parseRelFile )
2928
import Path.Extra ( forgivingResolveFile', toFilePathNoTrailingSep )
3029
import Path.IO
3130
( XdgDirectory (..), doesFileExist, ensureDir, getXdgDir )
31+
import RIO.NonEmpty ( nonEmpty )
3232
import RIO.Process
3333
( HasProcessContext, exec, proc, readProcess_
3434
, withWorkingDir
@@ -462,7 +462,7 @@ buildDepsAndInitialSteps GhciOpts{..} localTargets = do
462462
let targets = localTargets ++ map T.pack ghciAdditionalPackages
463463
-- If necessary, do the build, for local packagee targets, only do
464464
-- 'initialBuildSteps'.
465-
case NE.nonEmpty targets of
465+
case nonEmpty targets of
466466
-- only new local targets could appear here
467467
Just nonEmptyTargets | not ghciNoBuild -> do
468468
eres <- buildLocalTargets nonEmptyTargets

src/Stack/Init.hs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ import qualified Data.ByteString.Char8 as BC
1515
import qualified Data.Foldable as F
1616
import qualified Data.IntMap as IntMap
1717
import Data.List.Extra ( groupSortOn )
18-
import Data.List.NonEmpty ( nonEmpty )
19-
import qualified Data.List.NonEmpty as NonEmpty
2018
import Data.List.NonEmpty.Extra ( minimumBy1 )
2119
import qualified Data.Map.Strict as Map
2220
import qualified Data.Set as Set
@@ -37,6 +35,8 @@ import Path.IO
3735
)
3836
import qualified RIO.FilePath as FP
3937
import RIO.List ( (\\), intercalate, isSuffixOf, isPrefixOf )
38+
import RIO.NonEmpty ( nonEmpty )
39+
import qualified RIO.NonEmpty as NE
4040
import Stack.BuildPlan
4141
( BuildPlanCheck (..), checkSnapBuildPlan, deNeededBy
4242
, removeSrcPkgDefaultFlags, selectBestSnapshot
@@ -138,7 +138,7 @@ instance Pretty InitPrettyException where
138138
<> flow "None of the following snapshots provides a compiler matching \
139139
\your package(s):"
140140
<> line
141-
<> bulletedList (map (fromString . show) (NonEmpty.toList names))
141+
<> bulletedList (map (fromString . show) (NE.toList names))
142142
<> blankLine
143143
<> resolveOptions
144144
pretty (ResolverMismatch resolver errDesc) =
@@ -624,7 +624,7 @@ checkBundleResolver initOpts snapshotLoc snapCandidate pkgDirs = do
624624
getRecommendedSnapshots :: Snapshots -> NonEmpty SnapName
625625
getRecommendedSnapshots snapshots =
626626
-- in order - Latest LTS, Latest Nightly, all LTS most recent first
627-
case NonEmpty.nonEmpty supportedLtss of
627+
case nonEmpty supportedLtss of
628628
Just (mostRecent :| older) -> mostRecent :| (nightly : older)
629629
Nothing -> nightly :| []
630630
where
@@ -704,7 +704,7 @@ cabalPackagesCheck cabaldirs = do
704704
when (nameMismatchPkgs /= []) $
705705
prettyThrowIO $ PackageNameInvalid nameMismatchPkgs
706706
let dupGroups = mapMaybe nonEmpty . groupSortOn (gpdPackageName . snd)
707-
dupAll = concatMap NonEmpty.toList $ dupGroups packages
707+
dupAll = concatMap NE.toList $ dupGroups packages
708708
-- Among duplicates prefer to include the ones in upper level dirs
709709
pathlen = length . FP.splitPath . toFilePath . fst
710710
getmin = minimumBy1 (compare `on` pathlen)
@@ -717,7 +717,7 @@ cabalPackagesCheck cabaldirs = do
717717
flow "The following packages have duplicate package names:"
718718
<> line
719719
<> foldMap
720-
( \dup -> bulletedList (map fromString (NonEmpty.toList dup))
720+
( \dup -> bulletedList (map fromString (NE.toList dup))
721721
<> line
722722
)
723723
dups

src/Stack/Lock.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ import Data.Aeson.WarningParser
1414
, jsonSubWarningsT, logJSONWarnings, withObjectWarnings
1515
)
1616
import Data.ByteString.Builder ( byteString )
17-
import qualified Data.List.NonEmpty as NE
1817
import qualified Data.Map as Map
1918
import qualified Data.Text as T
2019
import qualified Data.Yaml as Yaml
20+
import qualified RIO.NonEmpty as NE
2121
import Path ( parent )
2222
import Path.Extended ( addExtension )
2323
import Path.IO ( doesFileExist )

src/Stack/SDist.hs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import qualified Data.ByteString.Lazy as L
2424
import Data.Char ( toLower )
2525
import Data.Data ( cast )
2626
import qualified Data.List as List
27-
import qualified Data.List.NonEmpty as NE
2827
import qualified Data.Map.Strict as Map
2928
import qualified Data.Set as Set
3029
import qualified Data.Text as T
@@ -45,6 +44,8 @@ import Distribution.Version
4544
)
4645
import Path ( (</>), parent, parseRelDir, parseRelFile )
4746
import Path.IO ( ensureDir, resolveDir' )
47+
import RIO.NonEmpty ( nonEmpty )
48+
import qualified RIO.NonEmpty as NE
4849
import Stack.Build ( mkBaseConfigOpts, build, buildLocalTargets )
4950
import Stack.Build.Execute
5051
( ExcludeTHLoading (..), KeepOutputOpen (..), withExecuteEnv
@@ -209,7 +210,7 @@ getSDistTarball mpvpBounds pkgDir = do
209210
pkgFp = toFilePath pkgDir
210211
lp <- readLocalPackage pkgDir
211212
forM_ (packageSetupDeps (lpPackage lp)) $ \customSetupDeps ->
212-
case NE.nonEmpty (map (T.pack . packageNameString) (Map.keys customSetupDeps)) of
213+
case nonEmpty (map (T.pack . packageNameString) (Map.keys customSetupDeps)) of
213214
Just nonEmptyDepTargets -> do
214215
eres <- buildLocalTargets nonEmptyDepTargets
215216
case eres of
@@ -614,7 +615,7 @@ checkPackageInExtractedTarball pkgDir = do
614615
flow "Package check reported the following warnings:"
615616
<> line
616617
<> bulletedList (map (fromString . show) warnings)
617-
case NE.nonEmpty errors of
618+
case nonEmpty errors of
618619
Nothing -> pure ()
619620
Just ne -> prettyThrowM $ CheckException ne
620621

0 commit comments

Comments
 (0)