Skip to content

Conversation

@Haoming02
Copy link
Contributor

  • Add a new Node which patches the model to use sageattn3 on non-first/last blocks and non-first/last steps
  • Use PromptServer.instance.send_progress_text to notify the user if sageattn3 was not usable
  • Models without block_index (e.g. SDXL) will always use optimized_attention

@Haoming02 Haoming02 marked this pull request as draft December 31, 2025 07:43
@isaac-mcfadyen
Copy link

Just a small comment (I'm not a Comfy contributor) that most users probably won't know what optimized_attention is.

I assume it's the internal name for non-Sage attention i.e. SDPA? If that's the case, wording it more like Apply Sage Attention 3 to the middle blocks and steps, while using normal attention for the first/last blocks and steps might be more understandable.

@Kosinkadink
Copy link
Member

The message can say 'default attention' instead of 'optimized_attention', maybe.

rattus128
rattus128 previously approved these changes Jan 3, 2026
Copy link
Contributor

@rattus128 rattus128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haoming02 Haoming02 marked this pull request as ready for review January 6, 2026 05:54
@Haoming02 Haoming02 changed the title SageAttention 3 Override feat: Patch SageAttention 3 Node Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants