Skip to content

Commit 57bc831

Browse files
authored
Merge pull request #36 from combine/release/5.0.0
Release/5.0.0
2 parents 3b94576 + 7be295c commit 57bc831

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+11949
-6810
lines changed

.babelrc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@
55
],
66
"plugins": [
77
"react-hot-loader/babel",
8+
"transform-es2015-modules-commonjs",
89
"transform-class-properties",
910
"transform-decorators",
10-
"transform-object-rest-spread",
11-
["resolver", { "resolveDirs": ["common"] }]
11+
"transform-export-extensions",
12+
"transform-object-rest-spread"
1213
]
1314
}

.gitignore

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1+
npm-error.log
12
.env
23
node_modules
34
npm-debug.log*
45
.DS_Store
56

67
# ignore built static files
7-
dist/
8-
webpack-assets.json
8+
/dist
9+
/webpack-assets.json
10+
11+
# webpack-built server files
12+
server/renderer/*.built.js

README.md

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,31 +11,30 @@ promise that future updates will not break your existing application.**
1111

1212
## Get started
1313

14-
Install [yarn](https://github.com/yarnpkg/yarn) if you don't have it already:
15-
```
16-
npm install -g yarn
17-
```
18-
19-
Then copy environment variables and edit them if necessary:
14+
Copy environment variables and edit them if necessary:
2015
```
2116
cp .env.example .env
2217
```
2318

2419
Then:
2520
```
26-
yarn install
27-
yarn start
21+
npm install
22+
npm start
2823
```
2924

3025
Direct your browser to `http://localhost:3000`.
3126

3227
For production builds:
3328

3429
```
35-
yarn run prod:start
30+
npm run prod:build
31+
npm run serve
3632
```
3733

38-
Note: pm2 must be installed to run production builds.
34+
For Heroku, simply add a `Procfile`:
35+
```
36+
web: npm run serve
37+
```
3938

4039
## Directory Structure
4140
```
@@ -93,13 +92,13 @@ Make sure you have it installed:
9392
npm install -g mocha
9493
```
9594

96-
Tests should reside alongside the component/module/selector/etc that it is
97-
testing. For example:
95+
Tests should reside in `test/spec` in their appropriate folders:
9896

9997
```
100-
├── reducers
101-
│   ├── todos.js
102-
│   ├── todos.test.js
98+
├── test
99+
│   ├── spec
100+
│   │   ├── api
101+
│   │   │   ├── todos.test.js
103102
```
104103

105104
Tests can be written with ES2015, since it passes through `babel-register`.

client/index.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,6 @@ import App from 'containers/App';
1010

1111
const history = createHistory();
1212

13-
/* Images
14-
* This space is reserved for images that are required by server rendering,
15-
* e.g. the favicon and any other images that need to be in the base HTML file.
16-
*/
17-
import '../common/images/favicon.png';
18-
1913
// The root element of your app
2014
const rootElement = document.getElementById('app');
2115

@@ -25,7 +19,7 @@ const initialState = window.__INITIAL_STATE__;
2519
const store = configureStore(initialState, history);
2620

2721
const render = (Component) => {
28-
ReactDOM.render(
22+
ReactDOM.hydrate(
2923
<Provider store={store}>
3024
<AppContainer>
3125
<ConnectedRouter history={history}>

common/css/_functions.scss

Lines changed: 0 additions & 1 deletion
This file was deleted.

common/css/_variables.scss

Lines changed: 0 additions & 1 deletion
This file was deleted.

common/css/base/_fonts.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
// Import fonts here, from google, or whereever.
2+
@import url('https://fonts.googleapis.com/css?family=Open+Sans:400,600');

common/css/base/_overrides.scss

Whitespace-only changes.

common/css/base/_styles.scss

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
html, body {
2+
height: 100%;
3+
font-family: 'Open Sans', sans-serif;
4+
5+
p {
6+
font-size: 16px;
7+
line-height: 24px;
8+
}
9+
}
10+
11+
body {
12+
background-color: $white;
13+
}
14+
15+
#app {
16+
height: 100%;
17+
width: 100%;
18+
margin: 0 auto;
19+
}

common/css/base/_vendors.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
// Import bootstrap-sass as needed
2+
$bootstrap-sass-asset-helper: true;
3+
@import "~bootstrap-sass/assets/stylesheets/bootstrap/variables";
4+
5+
$screen-lg-min: $app-max-width !global;
6+
$container-lg: $app-max-width !global;
7+
8+
@import "~bootstrap-sass/assets/stylesheets/bootstrap/mixins";
9+
@import "~bootstrap-sass/assets/stylesheets/bootstrap/grid";

0 commit comments

Comments
 (0)