Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditHandler::getRecordEditingFields() and EditHandler::filterRecordEditingFields() are both private? #196

Open
mlewis-everley opened this issue Mar 11, 2020 · 0 comments

Comments

@mlewis-everley
Copy link
Contributor

I am not sure if this is intentional, but in trying to overcome #195 I thought I could just extend EditHandler and overwrite getRecordEditingFields to make changes.

But as this is a private method, I end up having to duplicate almost the entire class to add three lines of code.

Do you mind if I submit a PR to change these to protected @colymba ? Or is there a reason they are private?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants