Add context/messaging to frequent rejection reasons #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-salgado
requested changes
Aug 31, 2024
There was a problem hiding this comment.
This is amazing work @arelymartinez16!! There were a lot of different parts to this issue but you handled it all really well-just tested it locally and it's working great! I left a few minor comments, but this should soon be good to go 🚀
apps/admin-dashboard/app/routes/_dashboard.applications.$id._index.tsx
Outdated
Show resolved
Hide resolved
| @@ -22,6 +23,8 @@ export function ApplicationRejectedEmail({ | |||
| into our community at this time. | |||
| </Email.Text> | |||
|
|
|||
| <Email.Text>Rejection Reason: {rejectionReason}</Email.Text> | |||
|
|
|||
There was a problem hiding this comment.
Note for @ramiAbdou: maybe we want to move the rejection reason elsewhere in the email? Also, one of the rejection reasons is currently "Incorrect or suspicious LinkedIn" which might be an unclear rejection reason to share.
| @@ -0,0 +1,15 @@ | |||
| import { type Kysely } from 'kysely'; | |||
There was a problem hiding this comment.
Note for @ramiAbdou: reminder to update the timestamp in file name
tomas-salgado
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✏️
Closes #216
Key Features:
Type of Change 🐞
Checklist ✅