Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typing to DefinitelyTyped #20

Open
aanari opened this issue Mar 1, 2018 · 1 comment
Open

Add Typing to DefinitelyTyped #20

aanari opened this issue Mar 1, 2018 · 1 comment

Comments

@aanari
Copy link

aanari commented Mar 1, 2018

It would help TypeScript users and the adoption of this module, to add the typing file to DefinitelyTyped.

Here is the typing file I've implemented and am using in a real app now:

declare module "lottie-reactxp" {

  import * as React from "react";

  export interface ILottieProps {
    source: object;
    loop?: boolean;
    isStopped?: boolean;
    duration?: number;
    width?: number;
    height?: number;
    style?: object;
    onComplete?: () => void;
    onLoopComplete?: () => void;
  }

  class Lottie extends React.Component<ILottieProps, any> {}

  export default Lottie;

}
@colmbrady
Copy link
Owner

Hi @aanari - Do you think you could submit a PR to that project? I could add some documentation in this repo to ensure it gets updated/maintained whenever props are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants