Keep compatibility since Emacs has removed typo. #46
Conversation
There was a problem hiding this comment.
IMO, define an alias for chinse-two-byte to keep compatibility would be better.
There was a problem hiding this comment.
You're right ,I think.
Emacs's compatibility advantage is a significant benefit of the ecosystem. Therefore, keeping compatibility is a more reasonable solution when dealing with outdated code
There was a problem hiding this comment.
Emacs 24.3, released in 2013, has already been around for 10 years, and given the modern features introduced after Emacs 28, it's reasonable to expect correct spellings.
There was a problem hiding this comment.
But rx--categories is a constant variable, create an alias is hard.
I don't know how to hack rx, rx--translate-form, rx--translate-category for use the modified rx--categories to provide chinse-two-byte.
May be directly drop typo is better.
There was a problem hiding this comment.
Emacs 24.3, released in 2013, has already been around for 10 years, and given the modern features introduced after Emacs 28, it's reasonable to expect correct spellings.
I mean keep compatibility for pangu-spacing, not the GNU Emacs. As I know, most of user used this package did not use the latest Emacs.
There was a problem hiding this comment.
I don't have machine installed Emacs 24.3.
I have checked Emacs 28.2/29.4 in Nixpkgs, it seems work and no side effects.
There was a problem hiding this comment.
pangu-spacing/pangu-spacing.el
Lines 162 to 169 in 2303013
Emacs versions 21.1 to 24.3 have incorrect spellings, later versions ( above 24.3 ) may include both correct and incorrect spellings (not sure).
Latest versions keep the correct spellings and remove the incorrect ones.
There was a problem hiding this comment.
It doesn't seem like a good idea to hardcode the version number, but I couldn't find a way to detect the current available rx--categories, maybe it's just something I've missed?
There was a problem hiding this comment.
but I couldn't find a way to detect the current available rx--categories
Have you try assq?
(assq 'chinese-two-byte rx--categories)
There was a problem hiding this comment.
I will combine the above content into a single commit. 😄
nailuoGG
force-pushed
the
remove-old-version-support
branch
from
7e5ff55 to
93c4735
Compare
nailuoGG
changed the title
|
It's time to review the commit that sums up the updates we've discussed so far. 😄 |
the missing `chinse-two-byte` may broken the package emacs-mirror/emacs@4437d73
nailuoGG
force-pushed
the
remove-old-version-support
branch
from
93c4735 to
000aa10
Compare
nailuoGG
force-pushed
the
remove-old-version-support
branch
from
8098fba to
4590bd5
Compare
the missing
chinse-two-bytewill break the main process, since emacs 31 remove the typo,emacs-mirror/emacs@4437d73
fix #45