Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issue #24

Open
coldnew opened this issue Oct 17, 2017 · 5 comments
Open

Performance Issue #24

coldnew opened this issue Oct 17, 2017 · 5 comments

Comments

@coldnew
Copy link
Owner

coldnew commented Oct 17, 2017

see:
https://emacs-china.org/t/topic/4043
https://emacs-china.org/t/topic/3816

@AmanYang
Copy link

AmanYang commented Jan 9, 2018

Hello cloldnew,
When enabling global-pangu-spacing-mode', I cannot open large files. The emacs process will be stuck in pangu-spacing-check-overlay'.
Is there any way to avoid this?

@coldnew
Copy link
Owner Author

coldnew commented Jan 9, 2018

@AmanYang Can you tell me how large the file you open with ?

I think the problem is due to when open file, pangu-spacing-mode will search from (point-min) to (point-max), which as known as the buffer size (file size).

To solve this issue, I should limit pangu-spacing-mode not search full file but just search user's view area instead.

@AmanYang
Copy link

AmanYang commented Jan 9, 2018

When the size of file is larger than 1M, can see obviously slow. When larger than 10M, completely frozen.

@yangsheng6810
Copy link
Contributor

@AmanYang Could you try #28 to see if it works for you?

@AmanYang
Copy link

AmanYang commented Apr 1, 2019

@yangsheng6810 Yes. It works for me after a tiny change.
I got a compile error after applying your path.
pangu-spacing.el:218:1:Error: Wrong number of arguments: #[(beg end func regexp) "
Found that in pangu-spacing-check-overlay, the 2nd pangu-spacing-search-overlay took 2 arguments instead of 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants