Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page with all the official maps #227

Open
petrvecera opened this issue Jul 28, 2023 · 3 comments
Open

Add page with all the official maps #227

petrvecera opened this issue Jul 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@petrvecera
Copy link
Member

petrvecera commented Jul 28, 2023

We should add page which will list all the maps in the game and info about them.

One of the attributes should be:

  • Is in automatch (true / false) , because later you can expected that maps will be removed from automatch
  • Added in patch

TODO: Brainstorm / describe other attributes we need to add

My idea - list of maps | on the left side is the image / on the right side is the info.
Q: Do we need a single page for each map? Do we have that much info?
image

@petrvecera petrvecera added the enhancement New feature or request label Jul 28, 2023
@KingDarBoja
Copy link
Collaborator

The editor only provides the map list and modes, no description or whatsoever.

image

@petrvecera
Copy link
Member Author

Btw I came up with the idea for finding out the map pool. We can draw data from the stats.

What it would do, it would look at the patch groups we have here https://github.com/cohstats/coh3-stats/blob/master/config.ts#L48

It would calculate a from to for each patch group from: "2024-02-27" to: "2024-04-01", and it would pick a date in between of these dates. ... or actually we could just have config array with the date. Well doesn't matter. It would know a date - it would do a stats request to that date for example https://coh3stats.com/stats/games?from=2024-03-15&to=2024-03-15

And from the field "maps" it would know which maps were played on that day, we would know for each patch which maps are in the pool.

Or we could draw that from the file automatch_maps, which have static data for each map 🤷

My vision for the page:
image

@KingDarBoja
Copy link
Collaborator

I believe going with our statistics is better as we have a fixed list already without needing to process the maps from the stats.

As we are relying on the fixed automatch_maps dictionary to perform the filtering of the stats request data, seems to me redundant to have a query to obtain the map list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants